fix(ci,build): Debian eol fix #267
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SyntaxColoring
left a comment
SyntaxColoring
left a comment
There was a problem hiding this comment.
I know this is a draft, just some drive-by comments!
Comment on lines
2
to
6
| # We're stuck on Debian 10 (which will go EOL around 2022-08) because | ||
| # Debian 11 upgrades GNU Make to v4.3, which breaks Buildroot's build system. | ||
| # | ||
| # Upstream Buildroot has fixes for this (try grepping their CHANGES file for | ||
| # "4.3"), but those commits aren't currently in this fork. |
Contributor
There was a problem hiding this comment.
No objection to the archive.debian.org fix for now, but it's been a while since this comment was written. We might be on a new enough version of Buildroot that we can upgrade past Debian 10 now.
| ref: ${{github.ref}} | ||
| inputs: | | ||
| route: POST /repos/opentrons/buildroot/actions/workflows/build.yml/dispatches | ||
| mediaType: '{"previews": ["wyandotte"]}' |
Contributor
There was a problem hiding this comment.
What's this wyandotte thing?
Member
|
this should be fixed in #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Docker build and GitHub Actions workflow warnings
Changes:
Problem: Docker build failing with 404 errors because Debian 10 (Buster) went EOL on June 30, 2024
Solution: Configure Dockerfile to use archive repositories (archive.debian.org) instead of standard repositories
Files: Dockerfile
Problem: Warning about unexpected inputs (owner, repo, workflow-id, ref, inputs) in octokit/request-action@v2.x
Solution: Updated workflow to use the correct API format with route values and data parameter
Files: .github/workflows/build-branches.yml
Technical Details
This issue became apparent only after the tagging fix was pushed out.
Added archive repository configuration for Debian Buster in Dockerfile
Updated build-branches.yml to use the new octokit/request-action API format
Maintained compatibility with existing workflow functionality
Result
Docker builds now complete successfully
GitHub Actions workflow runs without deprecation warnings
All functionality preserved