Another item delete #623
Merged
Another item delete #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75% of the way there...
Just trying to tie up loose ends and add some polish
* Also cleaning up unused/unneeded functions and comments * Leaving css to work on proper modal later
* Added a warning that names cannot start with a number
* Tweaked `spec/def` for `::name` and `::type` of items ("magic" items)
+ FIXED a long standing bug with the individual Item (View) Page; the Edit button now works
+ Replaced the Option Source Name input with a datalist
This change brings with it two new functions
+ ADDED `plugin-datalist [label feat]` for building/returning the UI element
+ ADDED `get-plugin-names` a helper function to do exactly what it says
+ Refactored `validate-item-name` to use an existing common function
+ ADDED `owner?` requirement to show delete button on edit page for custom items
+ `plugin-datalist` now takes a `dispatch-event` so each builder can use it
+ Started switching and testing each builder, as follows:
* feat-builder
* subclass-builder
* subrace-builder
* race-builder
* background-builder
* selections-builder
+ Finished swapping the inputs for the Option Source Name fields over to the datalist + Fixed the Delete button always showing on the Item Builder Page + Stylized the delete "modal" a bit + Stylized the name validation error
+ Dropdowns/selections for adding equipment in the character builder now sorts as case insensitive. lower case magic items are no longer shunted to the bottom of the list.
+ added `aloof-sort-by` + replaced multiple uses of (sort-by :name [...]) for consistency
* `.orcbrew` files should no longer export as empty when using the link in the warning banner
* Added some basic firearm templates for people to use in homebrewing * Added sorting to the weapon menu of the item builder * Added sorting to the weapon proficiency dropdown
* Added homebrew firearms for people to use as a jump-off point
+ ADDED `Light?` Weapon Property to the Item Builder for Custom Weapon Types + FIXED default values not loading for Custom Weapons, leaving properties blank when people didn't have reason to change them.
* Prevents the site from firing calls off to get the user/items db when they're not even logged in yet
* ADDED an `env` flag for `dev-mode` in the `:dev` profile via `lein-environ` * No need for the script unless it's being used or checked for errors, in which case set the `dev-mode` flag to false
Cleaning up for PR
Mostly so new eyes can better understand the shorthand syntax
datdamnzotz
requested changes
Sep 5, 2025
datdamnzotz
requested changes
Sep 5, 2025
datdamnzotz
left a comment
datdamnzotz
left a comment
There was a problem hiding this comment.
Can we put back in the .gitignore?
* My mind is a sieve - `orcpub/.git/info/exclude` EXCLUDE EXISTS! xd
Author
Added back in, with a note to myself to remember to stop forgetting |
* 2025 versions break something by bringing in ASM9
codeGlaze
dismissed
datdamnzotz’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #129
Fixes #361
Fixes #552
Fixes #611
Resolves #619
Fixes #622
Fixes #624
129 - Replaced the input for Option Source Name with a datalist that allows selection of existing orcbrews or creation of a new one.
361 - Added some generic Firearms and "flagged" them as being from DMV. This allows folks to at least make their own firearms more easily.
611 - Added a check to prevent names from starting with numbers, along with a warning popout.
619 - Adds a conditional delete button to the item builder, a delete button to item list entries, and fixes a bug in the item list > item view edit button
622 - A new sort-by wrapper has been created and applied to multiple lists in order to sort them and ignore casing.
624 - Finally squashed the long-standing bug (despite the issue being newly filed) in the banner, orcbrew now exports properly when clicking the prompt.
Also fixed some minor dev annoyances
homebrew.orcbrewerrors on dev buildsChecklist: