-
Notifications
You must be signed in to change notification settings - Fork 0
Dockerize 202411 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Dockerization support and several module/documentation updates aimed at reducing duplicated effort and streamlining deployment. Key changes include a new Run.ps1 entry script and Dockerfile, enhancements to module manifests and exported functions, and improvements to error handling and documentation across multiple modules.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Run.ps1 | Adds a new entry script to run AtlassianPowerKit under Docker |
| README.md | Updates usage instructions and Docker image references |
| Dockerfile | Provides a Dockerfile to build a PowerShell-based container for the module |
| AtlassianPowerKit-UsersAndGroups/*.psm1 | Minor formatting and documentation tweaks |
| AtlassianPowerKit-Jira/* | Updates to exported functions and error handling |
| AtlassianPowerKit-JSM/* | New functions for organization history and JSM request types |
| AtlassianPowerKit-GRCosm/* | New template and Node.js PDF generation script; functional enhancements |
| AtlassianPowerKit-Confluence/* | Updates to export/update Confluence pages and additional error handling |
| AtlassianPowerKit-Admin/*.psd1 | Module manifest updates |
| .gitmodules | Adds a new submodule for htmltoadf |
Comments suppressed due to low confidence (3)
AtlassianPowerKit-UsersAndGroups/AtlassianPowerKit-UsersAndGroups.psm1:13
- The update to include backticks around the inline code improves clarity; please ensure similar formatting is applied consistently throughout the module documentation.
- To list all functions in this module, run: Get-Command -Module AtlassianPowerKit-UsersAndGroups
Dockerfile:14
- Please verify that recursively setting permissions with 'chmod 755 -R /mnt' meets your container security requirements and does not expose unnecessary permissions.
RUN pwd && \
AtlassianPowerKit-GRCosm/generate-pdf.js:31
- Ensure that the headless mode setting is appropriately configured for your production environment to avoid unintended UI displays during PDF generation.
const browser = await puppeteer.launch({ headless: false }); // Use headless: true for production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSScriptAnalyzer found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Nearing completion but will not be this week, merging to avoid risk of duplicate work.