Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Dec 23, 2025

  • fixes checkBalance message value that gets sent to master strategy on withdrawal
  • simplifies the recipient check in the relay function
  • TODO: we might need to move Withdrawal event emission to onTokensReceived in Master strategy
  • adds approval of exact amount before depositing to Morpho Vault. We could stick with approving uint256.max?

@shahthepro shahthepro marked this pull request as ready for review December 24, 2025 05:49
@shahthepro shahthepro merged commit e694906 into shah/cross-chain-strategy-cctpv2 Dec 24, 2025
6 of 14 checks passed
@shahthepro shahthepro deleted the sparrowDom/cctpUnitTests branch December 24, 2025 05:49
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (shah/cross-chain-strategy-cctpv2@3585d9d). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             shah/cross-chain-strategy-cctpv2    #2724   +/-   ##
===================================================================
  Coverage                                    ?   41.45%           
===================================================================
  Files                                       ?      133           
  Lines                                       ?     6117           
  Branches                                    ?     1628           
===================================================================
  Hits                                        ?     2536           
  Misses                                      ?     3578           
  Partials                                    ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants