Feature/the basics #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/positioning box model
Complements css exercises for grid, media queries and layouts
pushdev-code
suggested changes
May 19, 2020
1-the-basics/style.css
Outdated
| @@ -0,0 +1,22 @@ | |||
| header, footer{ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| header, footer{ | |
| header, footer { |
1-the-basics/style.css
Outdated
| header, footer{ | ||
| background-color: coral; | ||
| } | ||
| form{ |
Contributor
There was a problem hiding this comment.
Suggested change
| form{ | |
| form { |
1-the-basics/style.css
Outdated
Comment on lines
5
to
7
| background-image: url(https://dissenyaweb.com/blog/diseno_web/wp-content/uploads/large-background-1024x724.jpg); | ||
| background-size: cover; | ||
| background-color: darkgoldenrod; |
Contributor
There was a problem hiding this comment.
sort css properties alphabetically so they're easy to find.
1-the-basics/style.css
Outdated
| background-size: cover; | ||
| background-color: darkgoldenrod; | ||
| } | ||
| button:hover{ |
Contributor
There was a problem hiding this comment.
Suggested change
| button:hover{ | |
| button:hover { |
1-the-basics/style.css
Outdated
| button:hover{ | ||
| background-color: darkorange; | ||
| } | ||
| aside{ |
Contributor
There was a problem hiding this comment.
Suggested change
| aside{ | |
| aside { |
1-the-basics/style.css
Outdated
| aside{ | ||
| font-size: larger; | ||
| } | ||
| p{ |
Contributor
There was a problem hiding this comment.
Suggested change
| p{ | |
| p { |
1-the-basics/style.css
Outdated
| color: white; | ||
| } | ||
|
|
||
| .font{ |
Contributor
There was a problem hiding this comment.
This class is not being applied to any element in your html, use it or remove it.
Contributor
There was a problem hiding this comment.
remove this class, is not being used.
pushdev-code
suggested changes
Jun 11, 2020
Contributor
pushdev-code
left a comment
pushdev-code
left a comment
There was a problem hiding this comment.
almost there, check the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.