Increase the max number of records read by kef2ph5 #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y large kef files, the program would fail.
dsentinel
reviewed
Nov 22, 2019
Contributor
dsentinel
left a comment
dsentinel
left a comment
There was a problem hiding this comment.
What's the failure mode? Have you hit this?
It's in a while True loop, so It shouldn't be limited, but only works on 10,000 at a time
Collaborator
Author
|
I can send you an example kef file that breaks this if you'd like? I was running into problems when trying to read very large kef files. Increasing the number of records read in each iteration of the loop fixed the issue, likely because it read them all on the first iteration. Please view this as a WIP. I think I need to take another look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kef2ph5would fail if a file contained more than 10,000 records.What does this PR do?
Increase the number of records that keftoph5 reads.
Checklist
CHANGELOG.txt.CONTRIBUTORS.txt.