Skip to content

Conversation

@timronan
Copy link
Collaborator

@timronan timronan commented Aug 19, 2020

Thank your for contributing to PH5

Before submitting a PR, please review the pull request guidelines:
https://github.com/PIC-IRIS/PH5/blob/master/CONTRIBUTING.md#submitting-a-pull-request

What does this PR do?

This pull request allows users to extract miniseed data from ph5 by querying by location code.

Relevant Issues?

Associated with #413

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@timronan
Copy link
Collaborator Author

timronan commented Aug 19, 2020

The test case included in this pull request updates a kef table to include a location code. Any of the SNCL's can have an added location code but we need to pick one so we can verify that the code works as expected. Adding a location code to the ph5/test_data/metadata/array_8_130.kef affects some of the other test, mainly just string output matching, which need to be updated. Is there a specific Array SNCL that we should add the location code to? Currently it was added to:

 /Experiment_g/Sorts_g/Array_t_008
     sensor/model_s = cmg-3t
     seed_station_name_s = 8001
     sample_rate_i = 100
     sample_rate_multiplier_i = 1
     das/serial_number_s = 9EEF
     pickup_time/ascii_s = Wed May 18 10:49:00 2016
     pickup_time/epoch_l = 1463568540
     pickup_time/micro_seconds_i = 0
     pickup_time/type_s = BOTH
     location/X/value_d = -106.916169
     location/X/units_s = degrees
     das/manufacturer_s = reftek
     das/model_s = rt130
     location/Y/value_d = 34.154673
     location/Y/units_s = degrees
     id_s = 8001
     location/Z/value_d = 1403
     location/Z/units_s = m
     deploy_time/ascii_s = Wed May 18 10:48:00 2016
     deploy_time/epoch_l = 1463568480
     deploy_time/micro_seconds_i = 0
     deploy_time/type_s = BOTH
     sensor/manufacturer_s = guralp
     channel_number_i = 1
     seed_band_code_s = H
     seed_instrument_code_s = L
     seed_orientation_code_s = Z
     seed_location_code_s=01

@timronan timronan marked this pull request as draft August 19, 2020 22:22
@timronan timronan requested a review from dsentinel August 19, 2020 22:23
@timronan timronan marked this pull request as ready for review August 20, 2020 22:28
@timronan
Copy link
Collaborator Author

timronan commented Sep 8, 2020

Are there any updates or changes that need to be made so this PR will work as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants