🪲 [Fix]: Don't count filtered tests as failed tests #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies test result handling by removing all logic related to tests with "NotRun" status, focusing only on passed, failed, and inconclusive test outcomes. This change prevents filtered tests (which typically have "NotRun" status) from being counted as failed tests.
- Removed
$hasNotRunValuevariable and associated checks - Updated test failure condition to exclude NotRun tests
- Removed error reporting for tests that were not run
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies the test result handling logic in the
scripts/main.ps1file by removing all checks and reporting related to tests that were "NotRun". The script now only considers passed, failed, and inconclusive tests when determining test failures and reporting errors.Test result handling simplification:
NotRuntest status, including the$hasNotRunValuevariable, checks forNotRunin test failure conditions, and error reporting for tests that were not run. [1] [2] [3]