🪲 [Fix]: Fix setting the $ErrorView setting via inputs
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a validation step in the GitHub Actions workflow to ensure that the ErrorView variable is set to NormalView.
- Added a LogGroup block to print the ErrorView value.
- Included logic to throw an error if the ErrorView variable is not set correctly.
MariusStorhaug
changed the title
$ErrorView setting via inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes related to the handling of the
ErrorViewconfiguration in a GitHub Actions workflow. The changes streamline theErrorViewinitialization logic by removing redundant code and adding validation to ensureErrorViewis set correctly during runtime.Changes to
ErrorViewhandling:.github/workflows/TestWorkflow.yml: Added a validation step to confirm thatErrorViewis set to'NormalView'during the workflow execution. If not, an exception is thrown.action.yml: Introduced the assignment of theErrorViewenvironment variable from the input parameter for use in subsequent scripts.scripts/init.ps1: Removed the redundant initialization and validation logic forErrorView, as this is now handled directly in the workflow and action configuration.