🩹 [Patch]: Reintroduce GitHub App authentication #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces GitHub App authentication to the Update-FontsData workflow by replacing GITHUB_TOKEN permissions with GitHub App credentials. The change improves security by using app-based authentication instead of the default token permissions.
- Removes default GITHUB_TOKEN permissions and adds GitHub App client ID and private key configuration
- Updates the PowerShell script to establish GitHub App connection before performing git operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/Update-FontsData.yml | Removes GITHUB_TOKEN permissions and adds GitHub App authentication inputs |
| scripts/Update-FontsData.ps1 | Adds GitHub App connection initialization |
…mproved clarity and organization
…te-FontsData script
…e-FontsData script
… markdown formatting in GitHub step summary
…g group for improved accuracy
…g group for improved accuracy
…into reintroGHAPP
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the workflow and script responsible for managing font data in the repository. The changes improve permissions handling, enhance the script's functionality, and revise logging and output formatting for better clarity and integration with GitHub Actions.
Workflow Updates:
.github/workflows/Update-FontsData.yml: Changedpermissionsto an empty object ({}) to simplify permission management. AddedClientIDandPrivateKeysecrets for improved authentication. [1] [2]Script Enhancements:
scripts/Update-FontsData.ps1: Enhanced command execution by capturing output and returning formatted results. Added logic to handle multi-line output.scripts/Update-FontsData.ps1: Integrated GitHub App connection and repository handling to dynamically fetch the default branch.scripts/Update-FontsData.ps1: Improved log group naming for clarity, such as renaming "Latest Fonts" to "Getting latest fonts." Added GitHub-specific notices for no updates and detailed summaries for changes. [1] [2]scripts/Update-FontsData.ps1: Added structured logging for processing changes and streamlined branch-specific push behavior.Type of change
Checklist