Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jul 23, 2025

Description

This pull request includes updates to the scripts/Update-FontsData.ps1 script to streamline naming conventions and improve clarity in commit messages and pull request creation. The changes focus on simplifying branch naming, standardizing commit messages, and refining pull request titles and descriptions.

Updates to naming conventions:

  • Updated the branch naming pattern from auto-update-font-$timeStamp to auto-update-$timeStamp for consistency and simplicity. ([scripts/Update-FontsData.ps1L52-R52](https://github.com/PSModule/GoogleFonts/pull/71/files#diff-69d235ffacf154789a70d5e00a557ee83393c256cd9431a8b7be57cc41c3ad89L52-R52))

Improvements to commit and PR messages:

  • Modified the commit message from "Update-FontsData via script on $timeStamp" to "Update FontsData.json" for better clarity and alignment with the changes being committed. ([scripts/Update-FontsData.ps1L96-R96](https://github.com/PSModule/GoogleFonts/pull/71/files#diff-69d235ffacf154789a70d5e00a557ee83393c256cd9431a8b7be57cc41c3ad89L96-R96))
  • Simplified the pull request title and body by removing references to "Google Fonts" and using more generic phrasing. The title now reads "Auto-Update $timeStamp," and the body specifies updates to "the latest metadata" instead of "Google Fonts metadata." ([scripts/Update-FontsData.ps1L117-R127](https://github.com/PSModule/GoogleFonts/pull/71/files#diff-69d235ffacf154789a70d5e00a557ee83393c256cd9431a8b7be57cc41c3ad89L117-R127))

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copilot AI review requested due to automatic review settings July 23, 2025 15:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This patch simplifies the naming conventions and messaging in the font update automation script. The changes remove specific references to "Google Fonts" and make the automated branch names, commit messages, and PR titles more generic.

  • Simplifies branch naming from "auto-update-font-{timestamp}" to "auto-update-{timestamp}"
  • Changes commit message from timestamped format to simple "Update FontsData.json"
  • Updates PR title and body to remove "Google Fonts" references and use generic "metadata" terminology

@MariusStorhaug MariusStorhaug self-assigned this Jul 23, 2025
@MariusStorhaug MariusStorhaug added the NoRelease Do not create a release label Jul 23, 2025
@MariusStorhaug MariusStorhaug merged commit 424ec5f into main Jul 27, 2025
36 checks passed
@MariusStorhaug MariusStorhaug deleted the fix branch July 27, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NoRelease Do not create a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants