Updated to read baro as EST then change to New_York #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time zone is now being read in as EST, which matches the csv file, then is converted to America/New_York Closes #30
jonbry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Original code read baro time series as America/New_York, which applied the wrong TZ. This caused the baro data to be stored with America/New_York but it was really EST (#30) as well as complications downstream with the downloader app (PWD-MARS/shinyDownloadTools#19)
Resolution
Identified issue and verified in #30 as well as ran test to make sure it was correctly applying the change. Time zone is now being read in as EST, which matches the csv file, then is converted to America/New_York.
I would recommend running a larger test before merging since you will need to delete and reimport baro data from at least when the code was added to the baro file:
5d5b9c0#diff-e6b1cf10e378a1cb72004fddf971df66bc8c7aa71bc7ec632ce2f6e2b887f4e2R165
Closes #30