Skip to content

【CUDA Kernel No.136】 #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiaoYFBH wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

【CUDA Kernel No.136】 #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26142df
Standardize compare kernel and update backends/iluvatar_gpu/CMakeList…
LiaoYFBH Dec 4, 2025
0b1a77d
Standardize compare kernel and update backends/iluvatar_gpu/CMakeList…
LiaoYFBH Dec 4, 2025
7b1f155
Merge branch 'develop' of https://github.com/PaddlePaddle/PaddleCusto…
LiaoYFBH Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backends/iluvatar_gpu/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ file(
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/pool_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/put_along_axis_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/randint_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/reduce_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/rms_norm_grad_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/rms_norm_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/roi_align_kernel.cu
Expand Down Expand Up @@ -368,7 +367,6 @@ file(
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/partial_send_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/psroi_pool_grad_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/quantize_linear_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/reduce_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/repeat_interleave_grad_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/repeat_interleave_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/rmsprop_kernel.cu
Expand All @@ -391,7 +389,6 @@ file(
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/kps/elementwise_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/legacy/gpu/fp8_quant_blockwise_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/legacy/gpu/moe_combine_no_weight_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/legacy/kps/compare_kernel.cu
# kernels/gpu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/activation_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/activation_grad_kernel.cu
Expand Down Expand Up @@ -429,7 +426,6 @@ file(
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/scatter_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/scatter_grad_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/dist_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/legacy/kps/compare_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/kps/compare_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/cum_kernel.cu
${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/cum_grad_kernel.cu
Expand Down
1 change: 0 additions & 1 deletion backends/iluvatar_gpu/kernels/cuda_kernels/compare_kernel_legacy_register.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

#include "paddle/phi/core/kernel_registry.h"
#include "paddle/phi/kernels/legacy/compare_kernel.h"
// #include "paddle/phi/kernels/legacy/kps/compare_kernel.cu" // NOLINT

PD_CUSTOM_KERNEL_REGISTER(less_than_raw,
iluvatar_gpu,
Expand Down
2 changes: 1 addition & 1 deletion backends/iluvatar_gpu/kernels/cuda_kernels/reduce_kernel_register.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

#include "paddle/phi/core/kernel_registry.h"
#include "paddle/phi/kernels/gpu/reduce_kernel.cu" // NOLINT
#include "paddle/phi/kernels/reduce_kernel.h" // NOLINT

PD_CUSTOM_KERNEL_REGISTER(reduce,
iluvatar_gpu,
Expand Down
1 change: 0 additions & 1 deletion backends/metax_gpu/kernels/cuda_kernels/compare_kernel_legacy_register.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include "paddle/phi/core/kernel_registry.h"
#include "paddle/phi/kernels/legacy/compare_kernel.h"
// #include "paddle/phi/kernels/legacy/kps/compare_kernel.cu" // NOLINT

PD_CUSTOM_KERNEL_REGISTER(less_than_raw,
metax_gpu,
Expand Down
1 change: 0 additions & 1 deletion backends/metax_gpu/kernels/cuda_kernels/reduce_kernel_register.cu
View file
Open in desktop
Copy link
Member

@YqGe585 YqGe585 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

编译报错，ReduceAMaxGradKernel找不到声明，需要解决

Copy link
Contributor Author

@LiaoYFBH LiaoYFBH Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

老师，这个报错应该是NO.95的paddle/phi/kernels/gpu/reduce_kernel.cu的头文件里namespace phi少了ReduceAMaxGradKernel。我把这个ReduceAMaxGradKernel加到paddle/phi/kernels/reduce_kernel.h里，然后提一个PR了

Copy link
Member

@YqGe585 YqGe585 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
// limitations under the License.

#include "paddle/phi/core/kernel_registry.h"
#include "paddle/phi/kernels/gpu/reduce_kernel.cu" // NOLINT
#include "paddle/phi/kernels/reduce_kernel.h"

PD_CUSTOM_KERNEL_REGISTER(reduce,
Expand Down
Loading