Skip to content

Conversation

@Klakurka
Copy link
Member

@Klakurka Klakurka commented Dec 21, 2025

Description

Chronik-Client supports UNKNOWN token types now so we can use that instead of our CASHTOKENS fork.

Clearly the linter did a bunch of stuff so recommend reviewing with whitespace hidden.

Test plan

Make sure tx detection/retrieval is still working.

Summary by CodeRabbit

  • Chores

    • Replaced one Chronik client dependency with its newer package and removed now-unnecessary dependency pinning from the public manifest.
  • Tests

    • Updated test mocks and test wiring to align with the new Chronik client package and adjusted related imports and setup.

✏️ Tip: You can customize this high-level summary in your review settings.

@Klakurka Klakurka added this to the Phase 3 milestone Dec 21, 2025
@Klakurka Klakurka requested a review from chedieck December 21, 2025 22:49
@Klakurka Klakurka self-assigned this Dec 21, 2025
@Klakurka Klakurka added the dependencies Pull requests that update a dependency file label Dec 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 21, 2025

Walkthrough

Updates Chronik dependency from chronik-client-cashtokenschronik-client (v^4.1.0) in package.json; removes a resolutions entry; updates imports and test mocks to use chronik-client.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Replaced chronik-client-cashtokens with chronik-client (^4.1.0); removed resolutions entry that pinned chronik-client-cashtokens/ecashaddrjs
Service Layer
services/chronikService.ts
Import source changed from chronik-client-cashtokenschronik-client for Chronik client/types; verify type/runtime exports align
Unit Tests
tests/unittests/chronikService.test.ts, tests/unittests/handleUpdateClientPaymentStatus.test.ts
Test mocks updated to mock chronik-client (ChronikClient/useStrategy); test wiring and spy usage refactored; minor formatting tweaks

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • chedieck
  • lissavxo

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading from chronik-client-cashtokens to the latest chronik-client package.
Description check ✅ Passed The description covers the key points: rationale for the upgrade (UNKNOWN token type support), acknowledgment of linting changes, and a test plan for validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-chronik-client-410

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0ae808 and 7d1d89f.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run Tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Klakurka Klakurka merged commit 1c793b1 into master Dec 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants