feat: update for Essentials 2 & remove deprecation warnings #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop 3-series support
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project from Essentials Framework version 2.0.0 to 2.12.1 and removes deprecation warnings by modernizing the codebase. This is a breaking change that drops support for 3-series devices.
Key changes include:
- Updated PepperDashEssentials package reference from version 2.0.0 to 2.12.1
- Replaced deprecated Debug.Console calls with modern structured logging using PepperDash.Core.Logging
- Refactored template classes to use actual "MakeModel" naming convention throughout the codebase
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/epi-make-model.4Series.csproj | Updated PepperDashEssentials package version to 2.12.1 |
| src/MakeModelLogicDeviceFactory.cs | New factory class for logic devices with updated logging and framework version |
| src/MakeModelLogicDevice.cs | Modernized device class with structured logging and null-conditional operators |
| src/MakeModelFactory.cs | Removed old template factory file |
| src/MakeModelDeviceFactory.cs | New factory class for communication devices with updated logging |
| src/MakeModelDevice.cs | Modernized device class with structured logging and improved naming conventions |
| src/MakeModelCrestronDeviceFactory.cs | New factory for Crestron devices with updated framework version |
| src/MakeModelCrestronDevice.cs | Modernized Crestron device class with structured logging |
| src/MakeModelConfigObject.cs | Renamed configuration classes from template names to MakeModel convention |
| packages.config | Removed 3-series package configuration |
| epi-make-model.3Series.sln | Removed 3-series solution file |
| .vscode/settings.json | Added VS Code workspace configuration |
| .vscode/extensions.json | Added recommended VS Code extensions |
| .editorconfig | Added editor configuration for code formatting |
jonnyarndt
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop 3-series support