Skip to content

Conversation

@NetsuNegi
Copy link
Contributor

@NetsuNegi NetsuNegi commented Dec 28, 2025

  • Fixed the issue that technos cannot spawn survivors due to non-probabilistic reasons when the tech type was destroyed.
  • 修复了科技类型会因为非概率原因而无法生成出幸存者的问题.
  • Fixed the bug that vehicle survivor can spawn on wrong position when transport has been destroyed.
  • 修复了载具幸存者会被生成在错误的位置的bug.

@NetsuNegi NetsuNegi added Interaction Something related to interaction with other extension, program etc. Needs testing ⚙️T1 T1 maintainer review is sufficient Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@ltyylt
Copy link

ltyylt commented Dec 28, 2025

@NetsuNegi
Copy link
Contributor Author

It's already implemented in https://github.com/Phobos-developers/Phobos/blob/develop/src/Utilities/AresAddressInit.cpp#L30

alright, but why disable it

@NetsuNegi NetsuNegi changed the title [Ares Fix] Fix the bug that technos cannot spawn survivors if it has been killed by ignore defense damage [Ares Fix] 2 Bugfixes about spawn survivors Dec 29, 2025
@TaranDahl
Copy link
Contributor

TaranDahl commented Dec 29, 2025

I simply gave it a try, but it seems to be ineffective for the first bug. 🤔

@chaserli
Copy link
Contributor

It's already implemented in https://github.com/Phobos-developers/Phobos/blob/develop/src/Utilities/AresAddressInit.cpp#L30

alright, but why disable it

There were issues that couldn't confirm if they were actually the repercussion of this or something else. If you're also sure it's safe, toggle the tweak before releasing a dev build.

Copy link
Contributor

@CrimRecya CrimRecya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just have two small questions.

@momokama
Copy link

momokama commented Jan 1, 2026

the problem of "viehcle cannot spawn survivors" due to "suicide weapon" is unfixed yet.

@Coronia Coronia merged commit 7401bd3 into Phobos-developers:develop Jan 8, 2026
12 checks passed
@TaranDahl
Copy link
Contributor

@Coronia How did you verify that it worked? I just did the same test as @momokama, and the result shows that it isn't working.

@Coronia
Copy link
Contributor

Coronia commented Jan 8, 2026

we did several rounds of transport destruction test with survivability setting to 100%, and so far all passengers are alive

as for the Suicide weapon thing, I don't consider this as a bug or something that should be solved in this PR, it's another issue if anything

@TaranDahl
Copy link
Contributor

as for the Suicide weapon thing, I don't consider this as a bug or something that should be solved in this PR, it's another issue if anything

I think that's also a problem that should be addressed here, because

"Fixed the issue that technos cannot spawn survivors due to non-probabilistic reasons when the tech type was destroyed."

and this issue was caused by Ares using the wrong parameters, it is a non-probabilistic reason.
I will directly submit it to the dev branch to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog Interaction Something related to interaction with other extension, program etc. ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants