-
-
Notifications
You must be signed in to change notification settings - Fork 125
[Ares Fix] 2 Bugfixes about spawn survivors #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ares Fix] 2 Bugfixes about spawn survivors #2020
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
It's already implemented in https://github.com/Phobos-developers/Phobos/blob/develop/src/Utilities/AresAddressInit.cpp#L30 |
alright, but why disable it |
|
I simply gave it a try, but it seems to be ineffective for the first bug. 🤔 |
There were issues that couldn't confirm if they were actually the repercussion of this or something else. If you're also sure it's safe, toggle the tweak before releasing a dev build. |
CrimRecya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I just have two small questions.
|
the problem of "viehcle cannot spawn survivors" due to "suicide weapon" is unfixed yet. |
|
we did several rounds of transport destruction test with survivability setting to 100%, and so far all passengers are alive as for the Suicide weapon thing, I don't consider this as a bug or something that should be solved in this PR, it's another issue if anything |
I think that's also a problem that should be addressed here, because
and this issue was caused by Ares using the wrong parameters, it is a non-probabilistic reason. |
Uh oh!
There was an error while loading. Please reload this page.