Skip to content

feat(timer): 소켓을 통해 연동되는 참가자 정보를 API와 통일 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lucaseunchae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(timer): 소켓을 통해 연동되는 참가자 정보를 API와 통일 #68

lucaseunchae wants to merge 1 commit into from

Conversation

@lucaseunchae
Copy link
Member

@lucaseunchae lucaseunchae commented Jul 14, 2024

Pull Request

작업한 내용

  • 소켓에 연동된 참가자 정보 데이터도 { users, activeParticipants } 형태로 통일 했습니다.

PR Point

  • 타이머 작동이 잘 되는지, DB에 pomodoroCount값이 잘 증가하는지 등 확인 부탁드립니다!

📸 스크린샷

image

closed #60

@lucaseunchae lucaseunchae requested a review from habbiness July 14, 2024 04:29
@lucaseunchae lucaseunchae self-assigned this Jul 14, 2024
@lucaseunchae lucaseunchae linked an issue Jul 14, 2024 that may be closed by this pull request
sync-all-particiants로 넘겨주는 값을 API와 통일 #60
Open
1 task
@habbiness
Copy link
Contributor

habbiness commented Jul 14, 2024

방금 확인 마쳤습니다!
모두 다 잘 작동합니다
수고하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@habbiness habbiness habbiness approved these changes

Assignees

@lucaseunchae lucaseunchae

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sync-all-particiants로 넘겨주는 값을 API와 통일

3 participants

@lucaseunchae @habbiness