Add downstream CI to prevent breaking policyengine-us-data #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow will run policyengine-us-data's PUF tests to catch breaking changes in microimpute before they affect downstream packages. The test runs on PRs and pushes to main, helping developers know immediately if their changes break dependent packages.
|
|
Use Python 3.12 to match microimpute's minimum required version
Run 'make download' and 'make data' with TEST_LITE=True to properly test microimpute integration in policyengine-us-data's data generation pipeline
- Remove continue-on-error so the check accurately reflects pass/fail status - Add HUGGING_FACE_TOKEN environment variable for downloading required data - This ensures the CI properly blocks PRs that would break policyengine-us-data
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated testing of policyengine-us-data to catch breaking changes in microimpute before they're merged.
Motivation
Recent changes to microimpute broke policyengine-us-data's dataset generation (#133). This PR adds CI to prevent similar issues in the future.
Changes
Impact
Testing
The workflow will run on this PR itself, demonstrating the integration test.
Fixes #134
Related to #133