New Jersey TANF earned income disregard

[xudonglai0426]

Fixes #2217

Co-authored-by: VioletChen0916 VioletChen0916@users.noreply.github.com

🤖 Generated by Copilot at 268a820

Summary

✨📄🛠️

This pull request adds the New Jersey TANF earned income disregards as a new feature to the policy engine. It introduces new parameters, variables, and tests for calculating the countable earned income for TANF households in New Jersey, based on the state's administrative code. It also adds some auxiliary variables for tracking the months enrolled in TANF and the weekly hours worked by TANF recipients.

nj_tanf changes
earned income disregards
autumn leaves fall fast

Walkthrough

• Add New Jersey TANF earned income disregards as a new feature (link)
• Create new parameters for the earned income disregards, with values and references from the administrative code (link, link, link, link)
• Implement a new variable nj_tanf_countable_earned_income that calculates the amount of earned income that is considered for TANF eligibility and benefit amount, using the new parameters and the existing gross_earned_income variable (link)
• Add new input variables months_enrolled_in_tanf and hours_worked that record the duration and intensity of work for TANF recipients, and derive a new variable weekly_hours_worked from the latter (link, link, link)
• Write test cases for the nj_tanf_countable_earned_income variable, covering different scenarios of income, enrollment, and work hours, and the expected output according to the New Jersey rules (link)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (09c71fc) to head (16a9ae0).
⚠️ Report is 12401 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   97.18%   97.19%           
=======================================
  Files        1265     1269    +4     
  Lines       19997    20048   +51     
  Branches      163      163           
=======================================
+ Hits        19434    19485   +51     
  Misses        537      537           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MaxGhenis]

Since if statements aren't vectorized, we have to use where and select statements instead

[xudonglai0426]

OK. Is there an example shows how to use "select" statement or how to use "where" and "select" to achieve the function of "if" there? Originally, we are using a nested where function, it is not so readable although it passes all the test. That's why we are trying to use "if" function.

[leogoldman]

@xudonglai0426 see my comment in the review below. Select is much cleaner than nested where (although both are vectorized). if will still achieve the same result, but is not vectorized so it will be much slower.

[leogoldman]

Try to use variable names that aren't quite as long (but still descriptive) to make the code a bit easier to read. Also, avoid creating variables that are the opposite of existing variables (use the boolean inverse instead)

[leogoldman]

Suggested change

	person_meet_higher_work_hours_threshold = (
	weekly_hours_worked >= p.work_hours_threshold
	)
	person_meet_lower_work_hours_threshold = (
	weekly_hours_worked < p.work_hours_threshold
	)
	meets_hours_threshold = weekly_hours_worked >= p.work_hours_threshold

[leogoldman]

No need for a variable that is the opposite of the first variable. If you need to check if the number of hours is less than the threshold, you can use ~meets_hours_threshold, flipping all the booleans

[leogoldman]

Here's an example of how to use select():

policyengine-us/policyengine_us/variables/gov/states/nj/tax/income/nj_main_income_tax.py

Line 4 in 83b0d38

class nj_main_income_tax(Variable):

The function's first argument is a condition list, the second argument is the list of values to return if that condition is true, and the (optional) third argument is the value to return if none of them are true (by default this is zero). The function goes through the condition list and returns the corresponding value. For example, if the third condition is true, the third value in the return list would be returned.
Here, you would want something like
select( [ enrolled_in_tanf_first_month, meets_hours_threshold, ... ], [ gross_earned_income * ( 1-p.higher_work_hours.first_month_percent), gross_earned_income * (1 - p.higher_work_hours.consecutive_month_percent), ... ] )
You don't need to specify a default return value since you want zero anyway.

[leogoldman]

Since you want element-wise boolean operations, make sure you use & instead of and.

[hua7450]

Consolidated into #7123