-
Notifications
You must be signed in to change notification settings - Fork 201
fix: Add breakdown and label metadata to pseudo-breakdown parameters #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anth-volk
wants to merge
6
commits into
main
Choose a base branch
from
fix/fix-pseudo-breakdown-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7118 +/- ##
============================================
- Coverage 100.00% 79.67% -20.33%
============================================
Files 10 3649 +3639
Lines 144 52526 +52382
Branches 0 263 +263
============================================
+ Hits 144 41849 +41705
- Misses 0 10639 +10639
- Partials 0 38 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hua7450
requested changes
Jan 9, 2026
policyengine_us/parameters/calibration/gov/census/populations/by_state.yaml
Outdated
Show resolved
Hide resolved
Added missing breakdown and label metadata to 28 parameter files that had children with filing_status or state_code values but were missing the proper breakdown metadata on the parent node. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Added missing breakdown: [filing_status] to the 2 remaining pseudo-breakdown parameters in gov/contrib/congress/wftca. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Added missing breakdown: [state_code] to 10 HHS Medicaid and SMI parameters that had state code children but were missing the breakdown metadata. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ters Add breakdown metadata to IRS parameters with nested bracket+filing_status structure: - gov/irs/capital_gains/thresholds.yaml: Add breakdown: [range(1, 3), filing_status] - gov/irs/credits/elderly_or_disabled/phase_out.yaml: Add breakdown: [filing_status] to threshold These params had filing_status children but were missing breakdown metadata on the parent node. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add labels to 8 ParameterScale parents (covers 68 bracket params): - American Opportunity Credit amount - EITC phase-out joint filer bonus - Premium tax credit eligibility - Premium tax credit phase-out ending/starting rates - DC property tax credit elderly/non-elderly offset fractions - DC income tax rates Add labels to 10 breakdown parents (covers ~450 params): - SNAP BBCE asset limit, net income tests, classification requirements - Maryland TANF grant standard - Wisconsin standard deduction maximum - Wisconsin unemployment compensation subtraction phase-out base - SNAP standard medical deduction - SNAP additional household member allotment - Completed state programs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes `breakdown: [state_code]` to: ``` breakdown: - state_code ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
16ff878 to
2403caf
Compare
hua7450
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7117
Summary
breakdownmetadata to 28 parameter files that had children with filing_status or state_code enum values but were missing thebreakdownattribute on the parent nodelabelmetadata where neededChanges by category
Calibration parameters (4 files)
calibration.gov.census.populations.by_state- addedbreakdown: [state_code]and labelcalibration.gov.hhs.medicaid.totals.enrollment- addedbreakdown: [state_code]and labelcalibration.gov.hhs.medicaid.totals.spending- addedbreakdown: [state_code]and labelcalibration.gov.irs.soi.returns_by_filing_status- addedbreakdown: [filing_status]IRS parameters (14 files)
gov.irs.ald.loss.max- addedbreakdown: [filing_status]gov.irs.ald.misc.max_business_losses- addedbreakdown: [filing_status]and labelgov.irs.capital_gains.loss_limit- addedbreakdown: [filing_status]and labelgov.irs.credits.cdcc.phase_out.amended_structure.second_increment- addedbreakdown: [filing_status]gov.irs.credits.ctc.phase_out.arpa.threshold- addedbreakdown: [filing_status]gov.irs.deductions.itemized.salt_and_real_estate.cap- addedbreakdown: [filing_status]gov.irs.deductions.qbi.phase_out.length- addedbreakdown: [filing_status]gov.irs.income.amt.exemption.amount- addedbreakdown: [filing_status]and labelgov.irs.income.amt.exemption.phase_out.start- addedbreakdown: [filing_status]and labelgov.irs.income.exemption.phase_out.start- addedbreakdown: [filing_status]and labelgov.irs.income.exemption.phase_out.step_size- addedbreakdown: [filing_status]and labelgov.irs.investment.net_investment_income_tax.threshold- addedbreakdown: [filing_status]and labelgov.irs.payroll.medicare.additional.exclusion- addedbreakdown: [filing_status]gov.irs.unemployment_compensation.exemption.cutoff- addedbreakdown: [filing_status]and labelState parameters (10 files)
gov.states.ca.calepa.carb.cvrp.income_cap- addedbreakdown: [filing_status]and labelgov.states.il.tax.income.exemption.income_limit- addedbreakdown: [filing_status]gov.states.ks.tax.income.exemptions.by_filing_status.amount- addedbreakdown: [filing_status]gov.states.mn.tax.income.subtractions.social_security.reduction.increment- addedbreakdown: [filing_status]gov.states.ny.tax.income.deductions.itemized.phase_out.start- addedbreakdown: [filing_status]gov.states.ny.tax.income.deductions.itemized.reduction.incremental.lower.income_threshold- addedbreakdown: [filing_status]gov.states.ut.tax.income.credits.retirement.phase_out.threshold- addedbreakdown: [filing_status]gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold- addedbreakdown: [filing_status]gov.states.ut.tax.income.credits.taxpayer.phase_out.threshold- addedbreakdown: [filing_status]gov.states.wi.tax.income.additions.capital_loss.limit- addedbreakdown: [filing_status]Test plan
🤖 Generated with Claude Code