fix mapping issue (from qiuzhi)

[hczphn]

Fix a mapping issue

[gemini-code-assist]

Summary of Changes

Hello @hczphn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical mapping error within the compiler's kernel logic. The fix ensures that intermediate representation (IR) inputs are reordered correctly, preventing incorrect variable assignments and improving the overall integrity of the compilation process.

Highlights

• Corrected variable mapping logic: The indexing for var_new_id within the reorder_ir_inputs function in expander_compiler/src/zkcuda/kernel.rs was corrected by swapping the roles of j and k in the array access and assignment, ensuring variables are mapped correctly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a critical bug in the input variable reordering logic within the reorder_ir_inputs function. The original code had swapped indices when creating the new variable ID mapping, which could lead to incorrect behavior or panics due to out-of-bounds access. The fix correctly assigns the variable IDs, resolving the mapping issue. I have also included a minor formatting suggestion to maintain code style consistency.