Skip to content

[DO NOT MERGE] Memory Profiler #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zhiyong1997 wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Memory Profiler #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
beef312
clean up old profiler
zhiyong1997 Sep 12, 2025
0283f2f
macros rules to simplify code
zhiyong1997 Sep 12, 2025
86d6e40
adjust default threshold
zhiyong1997 Sep 12, 2025
4e5cedc
print memory stats
zhiyong1997 Sep 12, 2025
f191d3b
redirect each process's output
zhiyong1997 Sep 12, 2025
7ed6325
proper entering and exiting
zhiyong1997 Sep 15, 2025
b45c5fa
More detailed memory consumption
zhiyong1997 Sep 15, 2025
75d8931
detailed circuit and scratch
zhiyong1997 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions expander_compiler/src/zkcuda/proving_system/expander/prove_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,16 @@ where
ECCConfig: Config,
ECCConfig::FieldConfig: FieldEngine<CircuitField = F::CircuitField>,
{
eprintln!("Exporting to expander circuit...");
let mut expander_circuit = kernel.layered_circuit().export_to_expander().flatten();
expander_circuit.pre_process_gkr();
eprintln!("Expander circuit exported, n_layers = {}", expander_circuit.layers.len());

eprintln!("Preparing prover scratch pad...");
let (max_num_input_var, max_num_output_var) = super::utils::max_n_vars(&expander_circuit);
let prover_scratch =
ProverScratchPad::<F>::new(max_num_input_var, max_num_output_var, mpi_world_size);
eprintln!("Prover scratch pad prepared");
Comment on lines +31 to +40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PR adds many eprintln! calls for logging and debugging. While useful during development, they will print to stderr in all builds, which can be noisy and may have a performance impact. It would be better to use a dedicated logging framework like tracing or log. This allows controlling log output via levels (e.g., trace, debug, info) and enabling/disabling it easily for different build configurations (e.g., release vs. debug).


(expander_circuit, prover_scratch)
}
Expand Down
1 change: 0 additions & 1 deletion expander_compiler/src/zkcuda/proving_system/expander_no_oversubscribe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
pub mod api_no_oversubscribe;
pub mod profiler;
pub mod prove_impl;
pub mod server_fn;
78 changes: 0 additions & 78 deletions expander_compiler/src/zkcuda/proving_system/expander_no_oversubscribe/profiler.rs
View file
Open in desktop

This file was deleted.

Loading
Loading