[FIX] 관리자화면 시트뷰 개선과 디테일뷰로 이동되지않던 이슈 수정및 최적화 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/#147-MapViewController-Spilit
…r/#147-MapViewController-Spilit
…refactor/#156-AdminPage-refactoring
Walkthrough이 변경사항은 Admin 및 Map 관련 뷰와 컨트롤러에 대한 리팩토링과 기능 개선을 포함합니다. AdminBottomSheet의 동적 높이 조정, 딤드 뷰 제스처 개선, 키보드 해제 기능 추가, MapViewController의 상수 중앙화 및 뷰포트 처리 로직 단순화, 그리고 코드 구조 개선이 이루어졌습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant AdminBottomSheetViewController as BottomSheetVC
participant AdminBottomSheetView as BottomSheetView
User->>BottomSheetVC: Segment 선택
BottomSheetVC->>BottomSheetView: calculateCollectionViewHeight(for: items)
BottomSheetView-->>BottomSheetVC: 반환된 높이
BottomSheetVC->>BottomSheetVC: updateContainerHeight()로 동적 높이 조정
sequenceDiagram
actor User
participant AdminViewController as AdminVC
participant AdminView as AdminView
participant DetailController as DetailVC
User->>AdminView: 셀 선택
AdminView->>AdminVC: didSelectRowAt 호출
AdminVC->>AdminVC: dismissKeyboard()
AdminVC->>DetailVC: DetailController 생성 및 Reactor 주입
AdminVC->>DetailVC: pushViewController
sequenceDiagram
actor User
participant MapViewController as MapVC
User->>MapVC: 지도 뷰포트 진입
MapVC->>MapVC: isFirstViewportEntry 체크
alt 최초 진입
MapVC->>MapVC: 가장 가까운 매장 선택 및 포커스
else 이후 진입
MapVC->>MapVC: 클러스터링만 갱신
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…refactor/#156-AdminPage-refactoring
0Hooni
reviewed
Jul 26, 2025
Member
0Hooni
left a comment
0Hooni
left a comment
There was a problem hiding this comment.
PR 리뷰 남겼습니다. 코멘트에 대한 리플라이 주시면 감사하겠습니다.
리플 확인 후 Approve로 전환하도록 하겠습니다👍
수고하셨습니다
...ationLayer/Presentation/Presentation/Scene/Admin/AdminBottomSheet/AdminBottomSheetView.swift
Show resolved
Hide resolved
...ationLayer/Presentation/Presentation/Scene/Admin/AdminBottomSheet/AdminBottomSheetView.swift
Show resolved
Hide resolved
Comment on lines
+100
to
+101
| tableView.backgroundView = UIView() | ||
| tableView.backgroundView?.isUserInteractionEnabled = true |
Member
There was a problem hiding this comment.
이거 바텀시트 뒤에 탭할때 사라지게하는 관련 코드인거같은데
맞다면 디자인시스템에 PPModal(UIViewController+.swift에 위치) 참고해서 적용해보시면 좋을것같아요
Contributor
Author
There was a problem hiding this comment.
updateContainerHeight로 탭이 바뀔때마다 탭별로 컨테이너 영역의 높이가 동적으로 계산되게끔 작성했던것으로 기억ㅎ는데
PPModal 같은경우에는 modal의 높이를 한번만 주입하기때문에 UI 상단영역이 깨져서 적용했던것으로 기억합니다 😂
Member
There was a problem hiding this comment.
아마 PPModal도 값을 주입하지 않으면 동적으로 modal의 높이를 계산하도록 내부적으로 구현되어있을텐데 한번 확인해보시면 좋을거같아요.
@zzangzzangguy 내일까지 어려우시다면 일단 관리자페이지는 사용자 경험과는 크게 문제가 없으니 이대로 넘어가시고 추후 작업으로 이슈 빼두시면 좋을것 같습니다
Poppool/PresentationLayer/Presentation/Presentation/Scene/Admin/AdminViewController.swift
Outdated
Show resolved
Hide resolved
…r/#156-AdminPage-refactoring
…com/PopPool/iOS into refactor/#156-AdminPage-refactoring
0Hooni
requested changes
Aug 13, 2025
Poppool/PresentationLayer/Presentation/Presentation/Scene/Admin/AdminViewController.swift
Show resolved
Hide resolved
0Hooni
pushed a commit
that referenced
this pull request
Nov 12, 2025
* refactor/#147: Deletate 분리및 Extension 이동 * refactor/#147: 매직넘버 enum constaranits 분리 * refactor/#156: 관리자페이지에서 디테일뷰로 이동가능 바텀시트뷰 UI 수정 * style/#156: Apply SwiftLint autocorrect --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈
✅ 작업 사항
Summary by CodeRabbit
신규 기능
버그 수정
리팩터링