-
Notifications
You must be signed in to change notification settings - Fork 0
[RELEASE] V1.1.2 To Develop merge #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/v1.1.2 # Conflicts: # Poppool/Poppool.xcworkspace/xcshareddata/swiftpm/Package.resolved
Walkthrough이번 변경에서는 Xcode 프로젝트 설정 파일과 Info.plist에 대한 버전 업데이트와 네트워크 보안 정책 변경, 그리고 중복된 프레임워크 임베드 항목 제거가 이루어졌습니다. 코드나 공개 인터페이스에는 변화가 없으며, 모두 설정 관련 수정입니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Poppool/Poppool.xcodeproj/project.pbxproj(2 hunks)Poppool/Poppool/Resource/Info.plist(2 hunks)Poppool/PresentationLayer/LoginFeature/LoginFeature.xcodeproj/project.pbxproj(0 hunks)
💤 Files with no reviewable changes (1)
- Poppool/PresentationLayer/LoginFeature/LoginFeature.xcodeproj/project.pbxproj
🔇 Additional comments (2)
Poppool/Poppool/Resource/Info.plist (1)
26-26: 버전 정보 업데이트 확인CFBundleVersion이 "250725.1554"로 정상적으로 업데이트되었습니다.
Poppool/Poppool.xcodeproj/project.pbxproj (1)
441-441: 프로젝트 버전 설정 업데이트 확인Debug와 Release 구성 모두에서
CURRENT_PROJECT_VERSION이 "250725.1554"로 일관되게 업데이트되었습니다. Info.plist의 CFBundleVersion과도 일치합니다.Also applies to: 488-488
zzangzzangguy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lGTM
릴리즈버전 병합을 위한 PR
Summary by CodeRabbit