Skip to content

[RELEASE] v1.1.2 To Main merge #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0Hooni merged 61 commits into from
Jul 27, 2025
Merged

[RELEASE] v1.1.2 To Main merge #167

0Hooni merged 61 commits into from
Jul 27, 2025

Conversation

@0Hooni
Copy link
Member

@0Hooni 0Hooni commented Jul 26, 2025

릴리즈버전 병합을 위한 PR

0Hooni added 30 commits July 15, 2025 15:37
@0Hooni
feat/#159: fastlane match 구현
c90d8bb
@0Hooni
feat/#159: 번들 ID 와일드카드 추가
dc0e3f6
@0Hooni
chore/#159: Signing 세팅 추가
cd7903f
@0Hooni
feat/#159: 테스트플라이트 업로드 구현
9825231
@0Hooni
chore/#159: 환경변수 파일 ingnore
05608fd
@0Hooni
chore/#160: 앱 배포용 프로비저닝 설정 변경
35fb97b
@0Hooni
chore/#160: gitignore 설정 수정
925d2e4 
- 모든 env 파일 무시 규칙 추가
@0Hooni
feat/#160: LoginFeature 모듈 추가 및 기본 세팅
2c79e23
@0Hooni
feat/#160: 기존의 LoginScene 복사
1f016b5
@0Hooni
refactor/#160: 기존의 로그인 화면에 컨벤션 적용
381cadf
@0Hooni
refactor/#160: 기존의 로그인 리액터 이동 및 컨벤션 적용
0087729
@0Hooni
refactor/#160: SignUp 화면 이동 팩터리 메서드 패턴으로 수정
da92826
@0Hooni
refactor/#160: FAQ 화면 이동 팩토리 메서드 패턴으로 수정
b6a185c
@0Hooni
style/#160: 사용하지 않는 프레임워크 import 제거
1f8983d
@0Hooni
refactor/#160: 탭바 화면 전환을 팩토리 메서드 패턴으로 수정
939bbbf
@0Hooni
chore/#160: 데모에 필요한 에셋 추가
02807fe
@0Hooni
feat/#160: 데모에 필요한 의존성 추가
84c407a
@0Hooni
fix/#160: 메인 화면 기존 코드 이사
cd392b9
@0Hooni
refactor/#160: LoginFeature 교체 준비
74f0afb 
- DIContainer 의존성 추가
- 프로젝트에 필요한 의존성 추가
- Factory를 이용한 화면 전환으로 변경
@0Hooni
refactor/#160: 서브 로그인 교체
6ba01fc
@0Hooni
refactor/#160: Presentation 모듈에서 로그인 Controller 제거
03d30b4
@0Hooni
fix/#160: 최근 로그인 툴팁 중복 해결
9395200
@0Hooni
feat/#160: 키체인 서비스 결과 미사용을 위한 discardableResult 추가
a14f353
@0Hooni
test/#160: 로그인 데모를 위한 PresentationTesting 구성
d60bd2d 
- 화면 전환에 필요한 화면을 별도의 Mock 객체로 대체
@0Hooni
refactor/#159: 로그인 feature용 사이닝 추가
60fda63
@0Hooni
style/#160: 불필요한 output 할당 코드 제거
952fdb6
@0Hooni
Merge pull request #162 from PopPool/feat/#159-setup--fastlane
8da795b
@0Hooni
refactor/#160: Reactor에서 Controller 결합 제거
1445932
@0Hooni
refactor/#160: Mutation none 케이스 제거
29150dd
@0Hooni
refactor/#160: UserDefault 사용을 keyType 형태로 사용하도록 수정
0531b59
0Hooni and others added 24 commits July 19, 2025 18:01
@0Hooni
style/#160: import sort 적용
b281cfd
@0Hooni
refactor/#160: PPLabel 기본값 지정
f2ef29e 
- 임시로 지정해준거고 기존 코드들에 문제없게 해두었습니다.
- 추후 디자인 시스템 개편 과정에서 참고하도록 하겠습니다.
@0Hooni
refactor/#160: 로그인 화면 중복 코드로 인한 높은 유지비용 문제 개선
dd76f6e 
- 로그인 화면과 서브 로그인 화면은 일부 컴포넌트의 속성을 제외하고는 동일한 동작을 가져감
- 서브로그인과 로그인을 리액터의 상태에 기반하여 구분되도록 수정
- 추후 로그인 개선시 하나의 코드만 수정해도 동일하게 동작하도록 개선
@0Hooni
refactor/#160: 로그인 코멘트를 외부에서 주입받도록 수정
08da954 
- 요구사항 분석과정에서 코멘트의 변경이 main/sub 만으로 나뉘지 않을것으로 예측함
- 기존에 isSubLogin이라는 bool로 분기를 하던것도 LoginSceneType을 별도로 선언하여 타입 추가에 대한 대비
@0Hooni
Merge branch 'develop' of https://github.com/PopPool/iOS into fix/#160-…
2776719 
…recent-login-duplication

# Conflicts:
#	Poppool/PresentationLayer/SearchFeature/SearchFeature.xcodeproj/project.pbxproj
@0Hooni
refactor/#160: 불필요한 사이닝 아이덴티파이어 제거
fed1825
@github-actions
style/#160: Apply SwiftLint autocorrect
b05ef85
@0Hooni
fix/#160: 로그인 데모 수정
66b086d
@0Hooni
fix/#160: UserDefaultService 의존성 주입
46c2c68
@0Hooni
fix/#160: userDefault 정보 제거 추가
a916d96 
- 로그아웃이나 회원탈퇴시 정보 제거가 이루어지지 않고 있었음
- 해당 로직을 추가함
@0Hooni
refactor/#160: 툴팁 업데이트 방식 수정
1561ad5 
- View에서 Reactor의 인스턴스(userDefautService)를 직접 접근하는것을 방지
- Rx의 ViewController LifeCycle을 이용하도록 수정
@0Hooni
fix/#160: self → owner를 통해 약한 참조로 수정
58db220
@0Hooni
style/#160: factory를 이용하여 화면 전환을 설계하도록 일치
dc13c38
@0Hooni
style/#160: 오타 수정
24a8aa2 
- authrization → authorization
@github-actions
style/#160: Apply SwiftLint autocorrect
b953652
@0Hooni
fix/#160: deployment target 버전 수정
a3ff197
@0Hooni
Merge branch 'fix/#160-recent-login-duplication' of https://github.co…
11175ab 
…m/PopPool/iOS into fix/#160-recent-login-duplication
@0Hooni
style/#160: 오타 수정
5b2fd4e 
- authrization → authorization
@0Hooni
Merge pull request #164 from PopPool/fix/#160-recent-login-duplication
ea16fa8 
[FIX] 로그인 툴팁이 중복을 발생하던 문제 수정
@0Hooni
chore: package.resolve 매치
ac526ae
@0Hooni
Merge branch 'develop' of https://github.com/PopPool/iOS into release…
af36634 
…/v1.1.2

# Conflicts:
#	Poppool/Poppool.xcworkspace/xcshareddata/swiftpm/Package.resolved
@0Hooni
fix: http 통신 임시 허용
d6d8043
@0Hooni
fix: 프레임워크 중첩 제거
f3b05b1
@0Hooni
chore: 빌드 버전 수정
6de17e6
@0Hooni 0Hooni self-assigned this Jul 26, 2025
@0Hooni 0Hooni added the ✅ deploy 배포 label Jul 26, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/v1.1.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @coderabbitai 요약 to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

zzangzzangguy
zzangzzangguy approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@zzangzzangguy zzangzzangguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0Hooni 0Hooni merged commit e41ffa0 into main Jul 27, 2025
5 checks passed
@0Hooni 0Hooni deleted the release/v1.1.2 branch July 27, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zzangzzangguy zzangzzangguy zzangzzangguy approved these changes

Assignees

@0Hooni 0Hooni

Labels

✅ deploy 배포

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0Hooni @zzangzzangguy