-
Notifications
You must be signed in to change notification settings - Fork 0
[REFACTOR] 디자인 시스템에 맞게 Typeface 적용 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
419e4cb
feat/#161: 아토믹 폰트 시스템 타입 정의
0Hooni 5be94f5
feat/#161: 폰트 시스템 속성 정의
0Hooni a00b630
refactor/#161: 변수 이름 수정
0Hooni bea805f
feat/#161: 새로 정의한 폰트 시스템 기반의 커스텀 폰트 extension 구현
0Hooni 6b54f3e
feat/#161: 라벨 속성 유지한 텍스트 변경 메서드 구현
0Hooni 8bb7057
feat/#161: 새로운 PPLabel 생성자 추가
0Hooni d385484
refactor/#161: Attribute 유지해주는 text 변경 메서드 적용
0Hooni ad02e75
fix/#161: Attribute가 적용되지 않던 문제 수정
0Hooni 431816f
refactor/#161: 변수 이름 수정
0Hooni 59036b6
refactor/#161: 메서드 이름 수정
0Hooni a415b7f
feat/#161: TextField placeholder에 타이포 시스템 적용
0Hooni 0e5d7e5
feat/#161: 행간 배율이 아닌 실제 행간 값을 타이포시스템에 추가
0Hooni 1fc7ef8
fix/#161: placeholder의 행간이 맞지 않던 문제 수정
0Hooni 59c48bb
refactor/#161: PPLabel에 lineHeight 고정 적용
0Hooni 1972091
refactor/#161: Text Attribute 적용을 UILabel의 Extension으로 이동
0Hooni 1d04a27
refactor/#161: 메서드명 수정
0Hooni 1be0a29
refactor/#161: UIButton에 타이포 시스템을 반영하는 메서드 추가 및 적용
0Hooni 579f95f
docs/#161: 기존 메서드 deprecated 메세지 추가
0Hooni 704d0a4
fix/#161: 영문 폰트에서 수직 중앙 정렬이 적용되지 않던 문제 수정
0Hooni 8d2452c
refactor/#161: 새로운 타이포시스템 적용 메서드로 수정
0Hooni ea2292b
docs/#161: 추후 작업해야될 부분 주석 추가
0Hooni 8b32702
docs/#161: deprecated 메세지 추가
0Hooni eee3a26
refactor/#161: 새로운 타이포 기반 컴포넌트와 메서드로 변경
0Hooni 6580881
feat/#161: 한글 판독 extension 추가
0Hooni a88ba40
refactor/#161: 기존 메서드들을 새로운 메서드에 대응되도록 내부 로직 수정
0Hooni 58085a9
refactor/#161: 새로운 타이포 방식 적용
0Hooni a3b44d8
feat/#161: PPButton의 새로운 생성자 추가 및 기존 생성자 변경된 타이포 대응
0Hooni 52948f8
refactor/#161: 새로운 타이포 시스템 적용 메서드로 수정
0Hooni bde6ab1
style/#161: Apply SwiftLint autocorrect
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
Poppool/CoreLayer/Infrastructure/Infrastructure/Extension/String+.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import Foundation | ||
|
|
||
| public extension String { | ||
| var isHangul: Bool { | ||
| return "\(self)".range(of: "\\p{Hangul}", options: .regularExpression) != nil | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
Poppool/PresentationLayer/DesignSystem/DesignSystem/Extension/UIButton+.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import UIKit | ||
|
|
||
| public extension UIButton { | ||
| /// Style을 필요로하는 Text가 포함된 일반 버튼에서 사용 | ||
| func setText( | ||
| to text: String = " ", | ||
| with style: PPFontStyle, | ||
| for controlState: UIControl.State = .normal | ||
| ) { | ||
| let paragraphStyle = NSMutableParagraphStyle() | ||
| paragraphStyle.lineHeightMultiple = style.lineHeightMultiple | ||
| paragraphStyle.maximumLineHeight = style.lineHeight | ||
| paragraphStyle.minimumLineHeight = style.lineHeight | ||
|
|
||
| let attributedString = NSAttributedString( | ||
| string: text, | ||
| attributes: [ | ||
| .font: UIFont.PPFont(style: style), | ||
| .paragraphStyle: paragraphStyle, | ||
| .baselineOffset: style.baseLineOffset | ||
| ] | ||
| ) | ||
|
|
||
| self.setAttributedTitle(attributedString, for: controlState) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.