auth: Move method checking to Router #13153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Upstream PR cmouse/yahttp#30 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cmouse
force-pushed
the
auth-api-method-check
branch
5 times, most recently
from
a5dfd22 to
36d6e85
Compare
cmouse
force-pushed
the
auth-api-method-check
branch
from
36d6e85 to
78a0709
Compare
cmouse
force-pushed
the
auth-api-method-check
branch
2 times, most recently
from
5ee9cb6 to
fa8c436
Compare
cmouse
force-pushed
the
auth-api-method-check
branch
2 times, most recently
from
db635c8 to
fc2a59e
Compare
Pull Request Test Coverage Report for Build 7220508700
💛 - Coveralls |
cmouse
force-pushed
the
auth-api-method-check
branch
2 times, most recently
from
c4778aa to
8bca277
Compare
Member
|
This has >50 clang-tidy warnings |
cmouse
force-pushed
the
auth-api-method-check
branch
4 times, most recently
from
c7290cd to
b08c2ff
Compare
Habbie
reviewed
Dec 5, 2023
Member
Habbie
left a comment
Habbie
left a comment
There was a problem hiding this comment.
Looks good to me! Will need a review from Otto as well. There's a conflict in ws-auth.cc currently. If Otto agrees, we can finally merge this (after that conflict)
cmouse
force-pushed
the
auth-api-method-check
branch
from
b08c2ff to
96660ad
Compare
Contributor
Author
|
Conflict resolved. |
cmouse
force-pushed
the
auth-api-method-check
branch
2 times, most recently
from
d2848c1 to
d916956
Compare
Enables us to specify method routes for this later.
Enables us to specify method routes for this later.
Enables us to specify method routes for this later.
Enables us to specify method routes for this later.
…ariants Enables us to specify method routes for this later.
If method is not empty and it does not match the request, throw exception.
cmouse
force-pushed
the
auth-api-method-check
branch
3 times, most recently
from
0796055 to
ede7481
Compare
cmouse
force-pushed
the
auth-api-method-check
branch
from
ede7481 to
bfaeecb
Compare
omoerbeek
approved these changes
Dec 15, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This change moves the HTTP verb checking into YaHTTP router.
Checklist
I have: