Skip to content

Cleanup main model: Make components to be forward declared #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nitbharambe wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Cleanup main model: Make components to be forward declared #1142

nitbharambe wants to merge 12 commits into from
+366 −38

Conversation

@nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Sep 29, 2025

Idea is to make components forward declared to reduce coupling.

This draft PR is created for gathering thoughts and requirements as of now.

Changes proposed in this PR include:

  • Forward declared all components
  • Removed unecessary exception and logging includes.

@nitbharambe
change to forward declarations
34ba5b2 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe self-assigned this Sep 29, 2025
@nitbharambe nitbharambe added the improvement Improvement on internal implementation label Sep 29, 2025
@figueroa1395
Copy link
Member

figueroa1395 commented Oct 1, 2025

I like the cleanup. Now I wonder, should we move all_components.hpp to the component folder? Also seems intuitive to me to rename component.hpp to all_components_fwd.hpp, or somehow homogenize the two.

In addition, can we also include component_list in this "revolution"? Perhaps it now belongs in component.hpp and we try to keep all component related stuff in one location only.

@nitbharambe
change incldues
f889ae6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change incldues fix
9e8c714 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add component test includes
5cf953d 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add common test includes
be33aef 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add eigen ignore
ad81da1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nitbharambe and others added 6 commits December 11, 2025 12:47
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
473994d
@nitbharambe
remove TODO
5418455 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
a463032
@nitbharambe
add new test file include
b054e9f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove comments
424f032 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix assert missing
dffc4f4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review January 7, 2026 13:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

figueroa1395
figueroa1395 reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional thing is that perhaps #1142 (comment) is still relevant. Also, maybe triggering Copilot for review might be useful since missing things for a human due to the nature of this PR is very easy.

Rest looks good, just minor questions.

.clang-tidy

WarningsAsErrors: '*'

IgnoreHeaders: 'Eigen/.*'
Copy link
Member

@figueroa1395 figueroa1395 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious. Why was this necessary? If I understand correctly, this prevents clang-tidy from inserting/removing headers in our Eigen dependency?

power_grid_model_c/power_grid_model/include/power_grid_model/common/three_phase_tensor.hpp
// eigen properties
#include <Eigen/Dense>

#include <cassert>
Copy link
Member

@figueroa1395 figueroa1395 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed here? It is now included in common.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nitbharambe nitbharambe

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitbharambe @figueroa1395