-
Notifications
You must be signed in to change notification settings - Fork 100
if last name is anonymous - replace lastname variable from response
#171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
controllers/front/ListComments.php
Outdated
|
|
||
| if ($isLastNameAnonymous) { | ||
| $productComment['customer_name'] = $this->anonymizeName($productComment['customer_name']); | ||
| $productComment['lastname']= '...'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does $productComment['customer_name'] contain ? is it the first name ? in this case we should concatenate customer_name and lastname before sending it to the anonymizeName method.
If it's just a name I guess it's fine 🤔
I ask this because I see the anonymizeName method does split the parameter with a space, as if expecting a name in two parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite sure that if we want to improve Lastname anonymizing, we need to do it inside function anonymizeName (lines 96 - 112), or before calling it at line 73.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthieu-rolland customer_name contains first_name + last_name.
matthieu-rolland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @mjamroz for your PR 👍 just one question, as I'm not familiar with this module
|
Hello @mjamroz can you rebase the PR please ? |
a1b1ef8 to
bd1fbe4
Compare
AureRita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mjamroz
Thank you for your PR, I tested it and it seems to works as you can see :
Tested on :
9.0.0
develop
Because the PR seems to works as expected, It's QA ✔️
Thank you
Uh oh!
There was an error while loading. Please reload this page.