Skip to content

Conversation

@mjamroz
Copy link
Contributor

@mjamroz mjamroz commented Jun 21, 2023

Questions Answers
Description? Remove last name from response if anonymized name
Type? bug fix
BC breaks? no
Deprecations? no


if ($isLastNameAnonymous) {
$productComment['customer_name'] = $this->anonymizeName($productComment['customer_name']);
$productComment['lastname']= '...';
Copy link
Contributor

@matthieu-rolland matthieu-rolland Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does $productComment['customer_name'] contain ? is it the first name ? in this case we should concatenate customer_name and lastname before sending it to the anonymizeName method.

If it's just a name I guess it's fine 🤔

I ask this because I see the anonymizeName method does split the parameter with a space, as if expecting a name in two parts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite sure that if we want to improve Lastname anonymizing, we need to do it inside function anonymizeName (lines 96 - 112), or before calling it at line 73.

Copy link
Contributor Author

@mjamroz mjamroz Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthieu-rolland customer_name contains first_name + last_name.

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mjamroz for your PR 👍 just one question, as I'm not familiar with this module

@ga-devfront ga-devfront added this to the 8.0.0 milestone Oct 31, 2025
@ga-devfront
Copy link
Contributor

ga-devfront commented Nov 3, 2025

Hello @mjamroz can you rebase the PR please ?

Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mjamroz

Thank you for your PR, I tested it and it seems to works as you can see :

Capture d’écran du 2025-11-07 16-28-13 Capture d’écran du 2025-11-07 16-31-41

Tested on :
9.0.0
develop

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita self-assigned this Nov 7, 2025
@ga-devfront ga-devfront merged commit 8455fd8 into PrestaShop:dev Nov 7, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants