Provide absolute URL to fix routing issues #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jul 25, 2025
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Provide absolute URL to fix routing issues. Fixes potential issues coming from relative URLs not being reliable after symfony migration. See PrestaShop/PrestaShop#39185. cc @Touxten |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#39185 |
| Sponsor company | TRENDO s.r.o. |
| How to test? | Just test the module can be configured correctly and loads in the backoffice, so we didn't break anything or have some typo. (On nginx server, this could be problematic.) |
Touxten
approved these changes
Jul 25, 2025
ShaiMagal
approved these changes
Jul 25, 2025
boherm
approved these changes
Aug 12, 2025
Contributor
Author
|
@PrestaShop/qa-functional This can be tested normally, doesnt need developer time to test if configuration form works. |
Contributor
Author
|
Ping @PrestaShop/qa-functional @PrestaShop/committers for QA, this is required for this module to work on 9.0.x branch on NGINX. |
Codencode
approved these changes
Oct 8, 2025
PoulainMaxime
approved these changes
Oct 29, 2025
Nakahiru
approved these changes
Oct 30, 2025
Contributor
|
@Hlavtox can you just fix the cs fixer issue please. I update milestone version because on dev we got some deleted code, then we are going to do a major version. |
ga-devfront
approved these changes
Oct 31, 2025
ingridusta
approved these changes
Oct 31, 2025
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @Hlavtox,
Your PR is tested with :
PS_TAG=9-8.1-fpm-alpine3.21-nginx
PS_TAG=9.0.0-8.1
No regression detected on the module :
On the BO :
- The module is well displayed, no typo or no display error.
- All the functionalities that can be enabled or disabled on the BO have been tested on the FO (validation by employee, guest review, upvotes/downvotes, anonymization)
- Adding star criterias
On the FO :
- Modal to review
- Mandatory fields
- Pagination, numbers of comments
- Votes
It's QA approved ✅
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.