Skip to content

Conversation

@Codencode
Copy link

Questions Answers
Description? see: PrestaShop/PrestaShop#39218
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#39218
How to test? see: PrestaShop/PrestaShop#39218
Sponsor company @Codencode

@kpodemski
Copy link
Contributor

kpodemski commented Jul 28, 2025

Hello @Codencode

Thank you for this pull request.

When you remove the code, it's worth checking who added it and for what reason.

You can do that by opening the file on GitHub, clicking on the line, and usingthe "Git blame" feature:
image

You can see that this part of the code was added for a reason:
#48

Could you take a look and see if removing this code won't create a regression by bringing back the already fixed issue?

@Codencode
Copy link
Author

Codencode commented Jul 28, 2025

Hello @kpodemski, you're absolutely right. I tried tracking down which PR introduced that code but couldn't find it initially - then using git blame (as you suggested) I located it.

After testing, I can confirm the issue (PrestaShop/PrestaShop#15184) either no longer occurs or at least I couldn't reproduce it. Something must have changed in the meantime, so that line/instruction is likely no longer needed.

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Jul 28, 2025
@kpodemski
Copy link
Contributor

The only concern I have now is that if someone uses the updateRating event, it won't function anymore 🤔 I wonder if the problem isn't the fact that in this products module below something's missing and thus 1 star rating

@Codencode
Copy link
Author

@kpodemski,

I looked into it further, and indeed the change is not needed.
The issue has already been resolved with this PR: b93d8bf
In fact, when using the "dev" branch, the issue does not occur. Therefore, my PR is incorrect, and the problem will be fixed in the next module release.

@Codencode
Copy link
Author

I'm closing this because the issue has already been resolved with this PR: b93d8bf

@Codencode Codencode closed this Jul 29, 2025
@github-project-automation github-project-automation bot moved this from Ready for review to Closed in PR Dashboard Jul 29, 2025
@Codencode Codencode deleted the fix-39218-Ratings-change-from-real-star-rating-to-one-star-in-same-category-products branch July 29, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Ratings change from real star rating to one star in same category products

2 participants