-
Notifications
You must be signed in to change notification settings - Fork 71
Update latvian and russian translations #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
tleon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the contribution. Could you provide informations on your contribution in the table available in description of this PR ? That would greatly help our teams to handle the contribution.
|
Sorry, is it ok now? |
matks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, a lot better now 👍 thank you
|
I do not have the language skills to validate whether your RU and LV translations are correct however I can tell that, if I use Google Translate, the obtained text is a lot closer to the other translation meanings 😉 |
florine2623
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zucha ,
I don't see the fix with your PR.
I tried to update the module psgdpr, I tried installing the shop in latvian and russian, I updated both languages from the BO.
But I still get the gdpr message in English in the shopping cart and in the customer account area.
Am I missing something ?
matthieu-rolland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @zucha for your PR 👍
lgtm code wise, I let you check @florine2623 's feedback
Uh oh!
There was an error while loading. Please reload this page.