feat: Always save final checkpoint in RLTrainer #690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure a checkpoint is saved at the end of training, regardless of save_steps interval. This fixes the issue where short runs (max_steps < save_steps) would produce no adapters. Changes: - Add _save_final_checkpoint() method to RLTrainer - Call it in _inner_training_loop finally block before cleanup - Save to broadcasts/step_N/ to match cleanup script expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure a checkpoint is always saved at the end of training, regardless of
save_stepsinterval.Problem
Short training runs (
max_steps < save_steps) produce no checkpoints because HuggingFace Trainer only saves atsave_stepsintervals. The cleanup job then finds nostep_*folder and deletes the adapter record.Solution
Add
_save_final_checkpoint()method that:_inner_training_loopfinally block (before orchestrator cleanup)broadcasts/step_{final_step}/directoryChanges
import osfor path operations_save_final_checkpoint()method_inner_training_loopfinally blockRelated