Run black 24.4.0 against the source. #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> All done! ✨ 🍰 ✨ > 18 files reformatted, 48 files left unchanged.
Member
Author
|
Hey @crwood! Does this look good to you? Is this going to break older Pythons? Should we just try it out? This is going to fix #481 (comment) so the typecheck job can get further. |
crwood
approved these changes
Nov 7, 2024
Member
crwood
left a comment
crwood
left a comment
There was a problem hiding this comment.
Thanks for this.
The code changes themselves all look fine, however, I'm seeing some errors that are new (to me at least) on CircleCI -- like this one ("no module named 'flaky'" for pyOpenSSL) and this one ("ipython-8.24.0 not supported for interpreter python3.9"). Have you seen these before/elsewhere? Were they already on your radar? If not, we should perhaps file tickets for them.
In any case, happy to merge this in the meantime.
Member
Author
Member
Author
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards making CI green again.