Adds es.json Humanization JSON #108
Conversation
📝 WalkthroughWalkthroughA new Spanish localization JSON file has been added to the EDTF PHP library. It provides comprehensive Spanish translations for date and time-related terms, qualifiers, and complex date expressions, including metadata and dynamic placeholders for flexible formatting. Changes
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
i18n/es.json (2)
7-7: Consider Using “Biblioteca PHP” Instead of “Librería PHP”In Spanish, “biblioteca” is commonly used for software libraries, whereas “librería” can be confused with “bookstore.” You may want to update the description accordingly.
18-29: Align Season Names’ Casing with Month NamesMonth names are in lowercase, whereas season names start with an uppercase letter. For consistency, consider lowercasing the season names. For example:
-"edtf-spring": "Primavera", +"edtf-spring": "primavera",Repeat similarly for the other season keys.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
i18n/es.json(1 hunks)
🔇 Additional comments (12)
i18n/es.json (12)
2-6: Metadata Block Looks GoodThe metadata includes the author’s information correctly and adheres to the expected structure for localization files.
8-10: Qualifier Translations Are CorrectThe translations for “maybe circa,” “circa,” and “maybe” are accurate and the placeholders are used consistently.
11-13: Verify Gender Agreement in Adjective FormsThe adjectives “incierta” and “aproximada” assume a feminine subject. If
$1can refer to masculine terms (e.g., “mes,” “año”), the gender will mismatch. Consider confirming the usage context or providing masculine variants to ensure grammatical correctness.
14-17: Date Part Labels Are ConsistentThe labels for “and prefix,” “day,” “month,” and “year” are accurate and align with the expected EDTF terminology.
30-38: Quarter, Quadrimester, and Semester Translations Are AccurateThe translations for quarters, quadrimesters, and semesters correctly reflect the intended meaning and use proper numbering and terminology.
39-44: Full Date and Year Formats Look GoodThe date formatting strings and BC year representations correctly use the placeholders in the proper order and include appropriate abbreviations.
45-56: Month Name Translations Are CorrectAll twelve month names are accurately translated into Spanish with correct spelling and lowercase formatting.
57-61: Interval Expressions Are Well TranslatedThe interval keys cover normal, open-ended, and unknown-bound intervals with clear Spanish phrasing.
62-69: Miscellaneous Date Terms Are AccurateTranslations for local time, empty set, “all of these,” “one of these,” and year-based range qualifiers are correct and idiomatic.
70-77: Month/Day Range and Comparison Expressions Are CorrectAll expressions for “and all earlier/later” and “or earlier/later” pertaining to months and days are properly phrased.
78-81: Season Range Expressions Look GoodThe qualifiers for seasons (“or earlier/later” and “and all earlier/later”) correctly follow the established pattern.
82-92: Set and One-of-These Constructs Are Properly RenderedThe inline set and range constructs for dates and years are accurately translated, including proper use of colons and placeholders.
|
Thanks! |
|
Gracias @JeroenDeDauw, really appreciate it! |
|
Released as 3.0.2 |
|
This should have done via translatewiki.net. I suspect once someone starts translating the automatic translation update here could remove all other message keys. |
|
AFAIK when @translatewiki syncs next time, they will pick up on the new translations, so unless someone touches stuff there beforehand, everything should be fine, and even if they do touch it beforehand, it might still be merged in. |
3 participants
See #107
We have this in production for a few years already. Would be great if it could become part of the main package. Thanks a lot
Summary by CodeRabbit