-
Notifications
You must be signed in to change notification settings - Fork 1
Fix WP CLI get task command & add tests #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test merged PR on Playground |
✅ Code Coverage Report
🎉 Great job maintaining/improving code coverage! 📊 File-level Coverage Changes (1 files)📈 Coverage Improved
ℹ️ About this report
|
Composer package changes
|
|
I have changed approach: Initially WP CLI commands were triggered like they are triggered from the command line, using exec. This worked fine locally (since it actually ran in local repo, not the test WP instance) but didnt in CI. To make it work I had to symlink repo to the test WP instance, create wp-config.php, install WP core, activate the plugin, change wp table prefix.. Now the WP CLI commands are tested from PHP directly, not using the exec command. This doesn't require any of the above steps and it is much faster. Also it feels more natural since.. this are PHP Unit tests. |
WP CLI get task command wasnt working after recent refactors, this PR fixes it and adds tests for following WP CLI commands (if WP CLI is available):