Skip to content

Conversation

@begumcig
Copy link
Member

@begumcig begumcig commented Nov 3, 2025

Description

VBench bencmarking suite depends on decord to read video frames, which doesn't have a package for MacOS

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@begumcig begumcig force-pushed the fix/installation-error-macos branch from 9cedb69 to 1888d46 Compare November 3, 2025 09:23
@begumcig begumcig requested a review from gsprochette November 3, 2025 09:31
Copy link
Collaborator

@gsprochette gsprochette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks for taking the time to identify and catch the ModuleNotFoundError. I assume there will be some sort of warning on pip install vbench for MacOS users, or at least a quick resolution of this sys_platform != 'darwin' :)

@begumcig begumcig merged commit 24e5546 into main Nov 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants