-
Notifications
You must be signed in to change notification settings - Fork 75
build: unpin torch version #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| dependencies = [ | ||
| "torch==2.7.0", | ||
| "torchvision==0.22.0", | ||
| "torch>=2.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unpinned torch conflicts with torch2.7-specific gptqmodel wheel
Unpinning torch to >=2.7.0 creates a version mismatch with the gptqmodel==4.0.0.dev0+cu126torch2.7 dependency (in the gptq extra). The gptqmodel wheel's version string explicitly indicates it was built for torch 2.7 (torch2.7 suffix), but users may now install torch 2.8+ while getting a gptqmodel binary compiled against torch 2.7's ABI. This can cause runtime errors or crashes when using GPTQ functionality due to binary incompatibility between the torch version and the gptqmodel extension.
|
@ParagEkbote you looked at unpinning the torch version in an other PR, would you like to review this? |
In this PR, why are we aiming to unpin the We could also define [project.optional-dependencies]
torch29 = [
"torch==2.9.0",
"torchao==0.14.1",
]
torch28 = [
"torch==2.8.0",
"torchao==0.13.0",
]Another point to be considered is that if we unpin WDYT? cc: @gsprochette |
|
This PR has been inactive for 10 days and is now marked as stale. |
Description
This PR unpins the torch version from "torch==2.7.0" to "torch>=2.7.0".
The version was pinned mainly to correspond to the version the stable-fast wheels were built against, so merging this PR will cause instability in the stable-fast install (in stable-fast and full extras) until we upload the new wheels (currently in testing).
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Ran the tests on torch 2.9 and made sure we are getting the same results as before
Checklist
Additional Notes