-
-
Notifications
You must be signed in to change notification settings - Fork 385
Upgrade to .NET 9 and OTAPI Static Hooks #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses dev instances unable to resolve binaries, and types being requested by the plugin manager before the resolver is attached
hakusaro
added a commit
that referenced
this pull request
Jan 27, 2025
This is part of #3050, but thinking about this logically, the deprecation of v3 happens in just 3 days, so unless we want to have .NET 9 testing done in the next 3 days (unlikely?), it's not a great idea to let this break.
Arthri
requested changes
Jan 28, 2025
Co-authored-by: Arthri <41360489+Arthri@users.noreply.github.com>
Arthri
approved these changes
Jan 29, 2025
windows is no longer part of the 9.0 manifest
Member
|
@SignatureBeef when you're ready, can you rebase? I will push out a pre-release with this and pgsql support once you've pushed it. |
Member
|
(same with the other branch on TSAPI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR until the sister PR at TSAPI is merged: Pryaxis/TSAPI#254Subsequently have not yet updated the submodule here, so CI is expected to fail currently.The specific TShock changes/todos are as follows:
For those who haven't looked at the TSAPI changes
(pending PR merge), it's changes are copied in below: