-
Notifications
You must be signed in to change notification settings - Fork 369
Refactor drone environments and merge back into one env #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I made an env based off your guys stuff FYI: |
|
@Kinvert - looks awesome! Maybe we should work (at some point in the future) on adding this to the main "drone" environment as a task. I think it would be super cool to have it all in one place, where you can pick and choose which tasks to train on given a scenario. :) |
|
Yep this is something I wanted to do after the hackathon but ran out of time. I had some small changes to that physics h file. Your envs might benefit actually from some sort of PID. iirc they seemed to be just training off the P portion. The Drone Delivery task could be simplified greatly by getting rid of the hidden_pos etc. This was done since we wanted the complexity in PufferLib and not have to manually move around the actual target position and velocity in Isaac Sim. |
|
I think the "I" is handled by the LSTM? |
|
Not sure they seemed to wobble to me, but I was in a hackathon and didn't have time to be thorough lol. |
Co-authored-by: Finlay Sanders <finlay_sanders@icloud.com>
|
Some things we are working on for the next version:
|
|
Worth noting that the current perf metric needs some work - we will make this nice soon. |
|
Rough sim2real todo:
|
|
Consider some actions noise too, latency, etc. Or maybe it was already there and I forgot. Physics noise. Also one thing I don't remember seeing, could have forgot or missed it, was how they can induce yaw by changing the 4 throttles. Was this accounting for torque of the blades? Gyroscopic effects of the blades? |
|
I think these bases are covered already but will double check :). I suspect for some of the aerodynamic forces there will be a tradeoff. ie. can we measure the constants accurately enough that including them will be worth it (or find them elsewhere) |
Major changes to drone environment to make development for sim2real easier: