Skip to content
This repository was archived by the owner on Sep 5, 2022. It is now read-only.

Conversation

@lee2998p
Copy link
Contributor

@lee2998p lee2998p commented Aug 6, 2020

Main Readme
Readme for the scripts folder
Readme for Retinaface

Copy link
Contributor

@stephend017 stephend017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main README looks really good but i think the usage section can be improved. it gets confusing when you list all the commands then explain them. I think a better format will be to list the command and what it does together.

The scripts and retinaface README's were a bit off. I think providing the entire API is overkill. I would rather see a description, what it should be used for and a small example code snippet of it being used.

@pawar4
Copy link
Contributor

pawar4 commented Aug 9, 2020

The usage section on the main readme needs to updated.

For example, we already provide a link to the drive folder in the Installation section, there is no need to link it again in Usage.

We also do not use the SSD model anymore. I would refer to Zach to find out which Retinaface model we are currently using. Also mention the fact that while we have 3 model, we are using Retinaface and we only test with retinaface.

Also the commands are outdated. We use a config file now to change our system settings rather than command inputs. The script that usage section is saying to call is also outdated. I would say to communicate with Jason and get details on how the system is ran and update the usage section respectively

@pawar4 pawar4 self-requested a review August 9, 2020 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants