Add tooltip popup on hover for pie chart #44
Draft
+117
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Working on cleaning up the code style, plus some broader structural/design improvements. Code is functional but slightly inefficient. The tooltip background is not exact - will need to consider using libraries like Pango for a way to get exact text-width measurements for the svg sizing. We'll see if the potential overhead worth it or negligible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hovering over the pie chart now shows the key and value.
Since the pie is rendered as SVG, the normal tooltips as divs don't work. Lots of trouble getting something to show up - it's just text for now.
More work will probably have to be done to get a white background rectangle behind the text.
Edit: Got the background lol. Pie chart key branch is finally done