Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@Ashwolaa
Copy link
Contributor

The implementation on the filtering was working directly on self.settings.

However, using the show method on the root element leads to some weird behavior resulting in losing the name of the settings.

This then leads to some issues for the saving/loading/updating as the xml format is not adapted to empty empty first element.

This PR now only apply filter on self.settings.children() to avoid it.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (873134c) to head (8e755ec).
⚠️ Report is 11 commits behind head on 5.0.x_dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           5.0.x_dev     #107      +/-   ##
=============================================
+ Coverage      63.63%   63.65%   +0.01%     
=============================================
  Files             74       74              
  Lines           9064     9068       +4     
=============================================
+ Hits            5768     5772       +4     
  Misses          3296     3296              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seb5g seb5g merged commit 3970ab9 into PyMoDAQ:5.0.x_dev Oct 23, 2025
20 of 28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants