This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Bugfix/ParameterManager_was_losing_name_attribute_when_filtering #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation on the filtering was working directly on self.settings.
However, using the
showmethod on the root element leads to some weird behavior resulting in losing the name of the settings.This then leads to some issues for the saving/loading/updating as the xml format is not adapted to empty empty first element.
This PR now only apply filter on self.settings.children() to avoid it.