fix: Properly shutdown the context in the CLI #710
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids leaving open a session after running commands and properly catches exceptions in the CLI commands.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to properly shutdown the context in the CLI and improve exception handling by adding try-except-finally blocks to the async_command decorator. The changes ensure that resources are cleaned up after running commands and that exceptions are properly caught and logged.
Key Changes:
- Added exception handling with try-except-finally block in the async command decorator
- Added logging for uncaught exceptions and error output to stderr
- Added cleanup call in the finally block to ensure resources are released
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids leaving open a session after running commands and properly catches exceptions in the CLI commands.
Pulled out from #709