Skip to content

Conversation

@allenporter
Copy link
Contributor

Split up the existing containers test into tests for the protocol specific subdirectories, following the newr roborock.data module structure.

This also updates all mock_data references to reference the tests path rather than a relative path.

Split up the existing containers test into tests for the protocol specific subdirectories, following the newr roborock.data module structure.

This also updates all mock_data references to reference the tests path rather than a relative path.
Copilot AI review requested due to automatic review settings December 27, 2025 18:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the test suite by splitting the monolithic tests/test_containers.py file into protocol-specific subdirectories under tests/data/, following the structure of the roborock.data module. Import statements across multiple test files have been updated from relative to absolute paths.

Key Changes

  • Split container tests into three separate files organized by protocol type (general, v1, and b01_q7)
  • Updated all mock_data imports from relative paths to absolute tests.mock_data imports
  • Created snapshot directory for v1 container tests

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_containers.py Removed monolithic test file (649 lines)
tests/data/test_containers.py New general container tests (RoborockBase, UserData, HomeData, camelization)
tests/data/v1/test_v1_containers.py New v1 protocol-specific tests (Status, Consumable, CleanRecord, MultiMapsList)
tests/data/b01_q7/test_b01_q7_containers.py New b01_q7 protocol-specific tests (B01Props deserialization)
tests/data/v1/snapshots/test_v1_containers.ambr Snapshot file for MultiMapsList test
tests/protocols/test_v1_protocol.py Updated mock_data import to absolute path
tests/devices/traits/v1/fixtures.py Updated mock_data import to absolute path
tests/devices/test_v1_device.py Updated mock_data import to absolute path
tests/devices/test_mqtt_channel.py Updated mock_data import to absolute path
tests/devices/test_device_manager.py Updated mock_data import to absolute path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant