Skip to content

Fix command line relative path resolution #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+33 −9
Draft

Fix command line relative path resolution #1857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd37e3f
Initial plan
Copilot Jan 13, 2026
88efbee
Fix relative path handling in command line arguments
Copilot Jan 13, 2026
b3ee2cf
Specify exception types in catch blocks for better error handling
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions QuickLook/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
using System.IO;
using System.Linq;
using System.Reflection;
using System.Security;
using System.Threading;
using System.Threading.Tasks;
using System.Windows;
Expand Down Expand Up @@ -126,8 +127,20 @@ protected override void OnStartup(StartupEventArgs e)
RunListener(e);

// First instance: run and preview this file
if (e.Args.Any() && (Directory.Exists(e.Args.First()) || File.Exists(e.Args.First())))
PipeServerManager.SendMessage(PipeMessages.Toggle, e.Args.First());
if (e.Args.Any())
{
try
{
var path = Path.GetFullPath(e.Args.First());
if (Directory.Exists(path) || File.Exists(path))
PipeServerManager.SendMessage(PipeMessages.Toggle, path);
}
catch (Exception ex) when (ex is ArgumentException || ex is SecurityException ||
ex is NotSupportedException || ex is PathTooLongException)
{
// Invalid path, ignore
}
}

// Exception handling events which are not caught in the Task thread
TaskScheduler.UnobservedTaskException += (_, e) =>
Expand Down Expand Up @@ -290,16 +303,27 @@ private bool EnsureFirstInstance(string[] args)
return true;

// Second instance: preview this file
if (args.Any() && (Directory.Exists(args.First()) || File.Exists(args.First())))
if (args.Any())
{
PipeServerManager.SendMessage(PipeMessages.Toggle, args.First(), [.. args.Skip(1)]);
try
{
var path = Path.GetFullPath(args.First());
if (Directory.Exists(path) || File.Exists(path))
{
PipeServerManager.SendMessage(PipeMessages.Toggle, path, [.. args.Skip(1)]);
return false;
}
}
catch (Exception ex) when (ex is ArgumentException || ex is SecurityException ||
ex is NotSupportedException || ex is PathTooLongException)
{
// Invalid path, continue to show duplicate message
}
}

// Second instance: duplicate
else
{
MessageBox.Show(TranslationHelper.Get("APP_SECOND_TEXT"), TranslationHelper.Get("APP_SECOND"),
MessageBoxButton.OK, MessageBoxImage.Information);
}
MessageBox.Show(TranslationHelper.Get("APP_SECOND_TEXT"), TranslationHelper.Get("APP_SECOND"),
MessageBoxButton.OK, MessageBoxImage.Information);

return false;
}
Expand Down