feat(terraform): implement terraform resource tab in terraform service overview #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and UI cleanup - Add terraform resources display feature with tree view and details panel - Group resources by type with expandable sections - Implement search functionality to filter resources by name/attributes - Auto-select first matching resource and maintain selection during search - Move terraform interfaces from shared to service-terraform domain scope for better encapsulation - Remove unused TerraformResourcesTable component and TerraformResourceKeyAttribute interface - Remove global axios interceptor workaround (fixed in qovery-typescript-axios v1.1.809) - Simplify TerraformResourcesSection to display-only (remove Apply button and deployment logic) - Update to qovery-typescript-axios v1.1.809 with proper type exports - Update page-general to display terraform resources in Overview tab - Add comprehensive test coverage for all new components
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
- Update qovery-typescript-axios from file reference to published v1.1.810 - Use TerraformResourcesResponse directly from qovery client - Simplify transformApiResponse to work with new API format - Remove unnecessary casting and type workarounds
fabienfleureau
force-pushed
the
feat/QOV-1444/tf_resources_page
branch
from
3075564 to
0342d44
Compare
…ctly
- Mock data should be an array, not { resources: [...] }
- useTerraformResources hook returns React Query result with data as array
- Fixes TypeError: data?.find is not a function in all terraform-resources-section tests
- All 8 terraform resource tests now pass
fabienfleureau
force-pushed
the
feat/QOV-1444/tf_resources_page
branch
from
0342d44 to
066ea73
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2317 +/- ##
===========================================
- Coverage 49.14% 47.72% -1.42%
===========================================
Files 811 1254 +443
Lines 16526 22714 +6188
Branches 4854 6634 +1780
===========================================
+ Hits 8121 10840 +2719
- Misses 6880 9809 +2929
- Partials 1525 2065 +540
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmnbrd
requested changes
Jan 21, 2026
libs/domains/service-terraform/data-access/src/lib/domains-service-terraform-data-access.ts
Outdated
Show resolved
Hide resolved
...ervice-terraform/feature/src/lib/terraform-resources-section/terraform-resources-section.tsx
Show resolved
Hide resolved
| import { type TerraformResource } from '@qovery/domains/service-terraform/data-access' | ||
|
|
||
| export function matchesSearch(resource: TerraformResource, query: string): boolean { | ||
| const lowerQuery = query.toLowerCase() |
Contributor
There was a problem hiding this comment.
@fabienfleureau A trim here and for all resources' properties could be nice
libs/domains/service-terraform/feature/src/lib/resource-tree-list/resource-tree-list.tsx
Outdated
Show resolved
Hide resolved
- remove unused title - simplify error handling in query function - fix clear search button
rmnbrd
requested changes
Jan 22, 2026
libs/domains/service-terraform/data-access/src/lib/domains-service-terraform-data-access.ts
Outdated
Show resolved
Hide resolved
rmnbrd
approved these changes
Jan 23, 2026
Member
|
🎉 This PR is included in version 1.270.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue:QOV-1444
add a page to show terraform resources
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release