simplify wait_readable loop + notify_closing #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
simplify-wait-readable-loop
branch
from
59898fb to
ac08333
Compare
graingert
force-pushed
the
simplify-wait-readable-loop
branch
from
d6d000d to
8ec402b
Compare
graingert
changed the title
graingert
commented
Apr 14, 2025
graingert
commented
Apr 14, 2025
graingert
commented
Apr 14, 2025
graingert
commented
Nov 14, 2025
graingert
commented
Nov 14, 2025
graingert
commented
Nov 14, 2025
Contributor
Author
|
@davidbrochart this is ready for review |
|
|
||
| @pytest.fixture | ||
| def sockets(contexts): | ||
| async def sockets(contexts): |
Member
There was a problem hiding this comment.
Why does it have to be async?
Contributor
Author
There was a problem hiding this comment.
the sockets.close() need to be called with the same running event loop that they are opened with. A sync fixture the close will happen outside the event loop and fail
davidbrochart
approved these changes
Nov 14, 2025
Member
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Thanks a lot @graingert, and glad that you're back!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on agronholm/anyio#896