N13/refactor send overlay #356
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps the hardware wallet. there may be another way to do this but for now dummy signature works well.
upgrade dependencies to pointy castle 4.0.0 to be compatible with the latest polkadart version. also upgrade human checksum dart to v1.1.0 tag so we are compatible with pointycastle.
The HW wallet will need to blake2 the output before signing.
These are useful as a reference implementation
removed uneeded file, fix doc comment, formatting
Alles was nicht erlaubt ist ist verboten!
also causes issues with the build
no need for hex encoding since UR is CBOR encoded
add known value test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC outline for how to refactor send overlay and hw wallet service
Not ready, needs to be tested ;)