N13/high security implementation 2 #363
Conversation
also added theme colors for the tags
fix data types and names which were wrong in the mock implementation
sanitized data types even more
remove a lot of text, add human checkphrase
didn't rename since we don't support multiple chains anyway
| } | ||
|
|
||
| // Wait for accounts to reload | ||
| await ref.read(accountsProvider.notifier).stream.firstWhere((state) => !state.isLoading); |
There was a problem hiding this comment.
Since accountsProvider is an AsyncValue. If we just want to wait for the future to resolve, we should just use await ref.read(accountsProvider.future); because listening to stream of state.isLoading seems not so reliable, there is a chance isLoading never flip to false. Better go with simpler and more reliable solution.
mobile-app/lib/features/main/screens/high_security/guardian_account_info_sheet.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/high_security/high_security_confirmation_sheet.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/high_security/high_security_details_screen.dart
Outdated
Show resolved
Hide resolved
| const HighSecurityDetailsScreen({super.key, required this.account}); | ||
|
|
||
| // Shared style accessors | ||
| static TextStyle text16(BuildContext context) => TextStyle( |
There was a problem hiding this comment.
Shouldn't this style go to theme file?
There was a problem hiding this comment.
No these are just some helpers for this specific screen...
| ), | ||
| ), | ||
| data: (data) { | ||
| if (data == null) { |
There was a problem hiding this comment.
Will we ever see this? or this is just to complete the possible data type case?
mobile-app/lib/features/main/screens/high_security/high_security_details_screen.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/high_security/high_security_details_screen.dart
Outdated
Show resolved
Hide resolved
| import 'package:resonance_network_wallet/providers/high_security_form_provider.dart'; | ||
| import 'package:resonance_network_wallet/providers/wallet_providers.dart'; | ||
|
|
||
| final highSecurityEstimatedFeeProvider = FutureProvider.family<BigInt, Account>((ref, account) async { |
There was a problem hiding this comment.
Same like before, shouldn't we just put in provider folder.
mobile-app/lib/features/main/screens/high_security/high_security_get_started_screen.dart
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/high_security/high_security_guardian_wizard.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/high_security/high_security_guardian_wizard.dart
Outdated
Show resolved
Hide resolved
| _SafeguardWindowSection(safeguardWindow: data.safeguardWindow), | ||
| const SizedBox(height: 20), | ||
| const _RemindersSection(reminders: reminders), | ||
| // const SizedBox(height: 20), |
There was a problem hiding this comment.
Why only comment? will it be used later?
There was a problem hiding this comment.
yeah once we have reminders
idk where to store them
on chain? task master? on the local?
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
LGTM! Just unsure about the watching stream if it's reliable or not. As long as you have tested it all good then
Features added
Next PR will be about guardian accounts being able to intercept transactions.